From owner-svn-src-all@FreeBSD.ORG Sun Sep 7 21:10:53 2014 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id BF511F8B; Sun, 7 Sep 2014 21:10:53 +0000 (UTC) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id B516F1D0A; Sun, 7 Sep 2014 21:10:51 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id AAA25144; Mon, 08 Sep 2014 00:10:34 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1XQjjF-0009l9-TR; Mon, 08 Sep 2014 00:10:33 +0300 Message-ID: <540CC991.3070604@FreeBSD.org> Date: Mon, 08 Sep 2014 00:09:37 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Slawa Olhovchenkov Subject: Re: svn commit: r260713 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs References: <201401161324.s0GDOADB008512@svn.freebsd.org> <20140907155641.GB72244@zxy.spb.ru> In-Reply-To: <20140907155641.GB72244@zxy.spb.ru> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Sep 2014 21:10:53 -0000 on 07/09/2014 18:56 Slawa Olhovchenkov said the following: > On Thu, Jan 16, 2014 at 01:24:10PM +0000, Andriy Gapon wrote: > >> Author: avg >> Date: Thu Jan 16 13:24:10 2014 >> New Revision: 260713 >> URL: http://svnweb.freebsd.org/changeset/base/260713 >> >> Log: >> fix a bug in ZFS mirror code for handling multiple DVAa >> >> The bug was introduced in r256956 "Improve ZFS N-way mirror read >> performance". >> The code in vdev_mirror_dva_select erroneously considers already >> tried DVAs for the next attempt. Thus, it is possible that a failing DVA >> would be retried forever. >> As a secondary effect, if the attempts fail with checksum error, then >> checksum error reports are accumulated until the original request >> ultimately fails or succeeds. But because retrying is going on indefinitely >> the cheksum reports accumulation will effectively be a memory leak. >> >> Reviewed by: gibbs >> MFC after: 13 days >> Sponsored by: HybridCluster > > No NFC yet > Is r256956 MFC-ed yet? -- Andriy Gapon