Date: Wed, 11 Sep 2019 11:04:07 +0000 (UTC) From: Kubilay Kocak <koobs@FreeBSD.org> To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r511814 - head/www/py-soupsieve Message-ID: <201909111104.x8BB47OY081365@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: koobs Date: Wed Sep 11 11:04:07 2019 New Revision: 511814 URL: https://svnweb.freebsd.org/changeset/ports/511814 Log: www/py-soupsieve: Add missing dependency soupsieve depends on backports.functools_lru_cache [1] on Python versions < 3, add the dependency accordingly. While I'm here: - Add TEST_DEPENDS and test target to improve future QA Note: soupsieve 'requires' [2] beautifulsoup4, but beautifulsoup4 depends on soupsieve via install_requires, causing a technical circular dependency, which is why soupsieve doesn't seem to explicitly install_requires on it ... anymore [3]. This seems bizzare. [1] requirements/project.txt: backports.functools_lru_cache ; python_version < '3' [2] https://github.com/facelessuser/soupsieve#installation [3] https://github.com/facelessuser/soupsieve/commit/9a792216ea1ffce018c7968105540c08b82b96db QA: 624 passed, 2 skipped, 6 warnings in 35.70 seconds PR: 240490 Reported by: jbeich Approved by: portmgr (blanket: missing dependencies, ports compliance) MFH: 2019Q3 (blanket(s): run-time bugfix) Modified: head/www/py-soupsieve/Makefile Modified: head/www/py-soupsieve/Makefile ============================================================================== --- head/www/py-soupsieve/Makefile Wed Sep 11 10:58:32 2019 (r511813) +++ head/www/py-soupsieve/Makefile Wed Sep 11 11:04:07 2019 (r511814) @@ -2,6 +2,7 @@ PORTNAME= soupsieve PORTVERSION= 1.9 +PORTREVISION= 1 CATEGORIES= www python MASTER_SITES= CHEESESHOP PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX} @@ -12,8 +13,23 @@ COMMENT= CSS4 selector implementation for BeautifulSou LICENSE= MIT LICENSE_FILE= ${WRKSRC}/LICENSE.md +TEST_DEPENDS= ${PYTHON_PKGNAMEPREFIX}pytest>0:devel/py-pytest@${PY_FLAVOR} \ + ${PYTHON_PKGNAMEPREFIX}html5lib>0:www/py-html5lib@${PY_FLAVOR} \ + ${PYTHON_PKGNAMEPREFIX}lxml>0:devel/py-lxml@${PY_FLAVOR} \ + ${PYTHON_PKGNAMEPREFIX}beautifulsoup>4:www/py-beautifulsoup@${PY_FLAVOR} + USES= python USE_PYTHON= autoplist concurrent distutils + NO_ARCH= yes -.include <bsd.port.mk> +.include <bsd.port.pre.mk> + +.if ${PYTHON_VER} < 3 +RUN_DEPENDS+= ${PYTHON_PKGNAMEPREFIX}backports.functools_lru_cache>0:devel/py-backports.functools_lru_cache@${PY_FLAVOR} +.endif + +do-test: + cd ${WRKSRC} && ${PYTHON_CMD} -m pytest -v -rs + +.include <bsd.port.post.mk>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201909111104.x8BB47OY081365>