From nobody Sun Jan 25 02:39:45 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dzG8y0vfxz6Q4gZ for ; Sun, 25 Jan 2026 02:39:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dzG8y07Wyz3ttp for ; Sun, 25 Jan 2026 02:39:46 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769308786; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ku7FasUyW3n9KTfjrXwbCDCbyY5v8/krqhEqrg6AGDw=; b=dKTVD6GqlwMdyOn1dygI4FD3CEY3Jcw641E5QwdsifvW+nqpwmvcq//9iFM3iUxLtVsdYF xTVsFTw3f+RhXznkb2AX9ucyX0sNV40hddS1yV+95Bu1fBtqCfVm7xNHfOnE+9rfw7+Mmw cAMtf4+knbwvOhITImvzZ+saLah00Gtp7FuWnfYIWlkMI4708JEL0MG9CF3hjbT/pCGitE gZvdJkZJkPk2ywJj0nOiUD7uv1w2RZfRrl5nuCsXzfPpU4WXNPk8b05SD1fW9TdzgOR5iG /mHESbSEovvMZzeBVThgMeIbtBU47pljZUu6W6cMD/4IWE/9nzwr0zc0Se9A4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769308786; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ku7FasUyW3n9KTfjrXwbCDCbyY5v8/krqhEqrg6AGDw=; b=RYTIRk3QZt8F8c5CLP5IndGxGn1ITcP39FqSGwmFglhH5rxOTszsceKX56GRW1aUxRfzqj bG7hp+/8Su2dOMc6RF5NeUjYk0y+LIqXceEoEJLeO774ANly6oJZpNn2Su74Mibdc9EQNt Qdlw2PUJB59W9GMGobmYppZnnelybfG3ZaWojSobYlDVasodr+96jidR7XkQ0FIhwO9gG/ Qx5n3HSruKAcNJ2BoET22ErrGkM4s+g4r9lAAQ5ErFIkJz/ZV5TG1xWHPQYgePXTDIHD+L 2yS5/cUtIyhbTAoTFmI2td2SRfVoVlgsAbpoiXEDWe7eiszxQ7VZGJMbDE8/cw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1769308786; a=rsa-sha256; cv=none; b=ZyKMj5UvJxH2bZMu/HG2l4EgHH6En8oifJeN29UmGqCJZWUuJkP7pGzioLU85XN5XYcTDO Sf0wrVkT/AB4L0O8bc/rBqbaG7m1YquyJjUNeTjLlmpu93I+gIk0+NIf7CalIMCtW+l0od LtiIM58PUUMB06yN3WqcZLNbuv2NC4PE+sVyVQbVV95fW67QFQswB4IKM7La+QAQc9S7kE zexSsUwDvEd8O6b+v/1rA60DyoWjJGuW47H7gmJOm6WPvDQz7tA7dtUvC7+Ky9FI3yMdis bFa03y2NgCRjHmdG3qLJtNTbKa+Z1w07r0F53mzezT9dOHmzfCfocpiid2CCSw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dzG8x6Dvmz1Yq for ; Sun, 25 Jan 2026 02:39:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 2502e by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 25 Jan 2026 02:39:45 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Siva Mahadevan Subject: git: a900227040b4 - stable/15 - tests/ktest_netlink_message_writer: remove INVARIANTS requirement List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: siva X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: a900227040b4b1b78b0a491b31d6773af50b617e Auto-Submitted: auto-generated Date: Sun, 25 Jan 2026 02:39:45 +0000 Message-Id: <69758271.2502e.2b9021fd@gitrepo.freebsd.org> The branch stable/15 has been updated by siva: URL: https://cgit.FreeBSD.org/src/commit/?id=a900227040b4b1b78b0a491b31d6773af50b617e commit a900227040b4b1b78b0a491b31d6773af50b617e Author: Siva Mahadevan AuthorDate: 2026-01-22 19:49:51 +0000 Commit: Siva Mahadevan CommitDate: 2026-01-25 01:53:34 +0000 tests/ktest_netlink_message_writer: remove INVARIANTS requirement INVARIANTS is meant to be used to enable extra sanity checking for internal structures, not enable/disable tests in the freebsd kyua test suite. STABLE branches include a GENERIC kernconf without INVARIANTS, so ktest_netlink_message_writer is broken on such branches: https://ci.freebsd.org/job/FreeBSD-stable-15-amd64-test/253/testReport/sys.netlink.test_netlink_message_writer/py/__test_cases_list__/ Reviewed by: lwhsu, imp Approved by: lwhsu (mentor) Pull Request: https://github.com/freebsd/freebsd-src/pull/1889 Signed-off-by: Siva Mahadevan Sponsored by: The FreeBSD Foundation (cherry picked from commit 8352e24d0bc59f9730980986600bde7d8cdce21d) --- sys/netlink/ktest_netlink_message_writer.c | 5 ----- sys/netlink/ktest_netlink_message_writer.h | 2 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/sys/netlink/ktest_netlink_message_writer.c b/sys/netlink/ktest_netlink_message_writer.c index 805f52197f69..0e8b962bbd34 100644 --- a/sys/netlink/ktest_netlink_message_writer.c +++ b/sys/netlink/ktest_netlink_message_writer.c @@ -37,8 +37,6 @@ #define KTEST_CALLER #include -#ifdef INVARIANTS - struct test_nlbuf_attrs { uint32_t size; uint32_t expected_avail; @@ -98,16 +96,13 @@ test_nlbuf_writer_allocation(struct ktest_test_context *ctx) return (0); } -#endif static const struct ktest_test_info tests[] = { -#ifdef INVARIANTS { .name = "test_nlbuf_writer_allocation", .desc = "test different buffer sizes in the netlink writer", .func = &test_nlbuf_writer_allocation, .parse = &test_nlbuf_parser, }, -#endif }; KTEST_MODULE_DECLARE(ktest_netlink_message_writer, tests); diff --git a/sys/netlink/ktest_netlink_message_writer.h b/sys/netlink/ktest_netlink_message_writer.h index 447593e0e700..1abf0d48de95 100644 --- a/sys/netlink/ktest_netlink_message_writer.h +++ b/sys/netlink/ktest_netlink_message_writer.h @@ -28,7 +28,7 @@ #ifndef _NETLINK_KTEST_NETLINK_MESSAGE_WRITER_H_ #define _NETLINK_KTEST_NETLINK_MESSAGE_WRITER_H_ -#if defined(_KERNEL) && defined(INVARIANTS) +#if defined(_KERNEL) bool nlmsg_get_buf_wrapper(struct nl_writer *nw, size_t size, bool waitok);