From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Jan 20 20:30:13 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DBB40106564A for ; Fri, 20 Jan 2012 20:30:12 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id ACBE28FC0C for ; Fri, 20 Jan 2012 20:30:12 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q0KKUC7q074318 for ; Fri, 20 Jan 2012 20:30:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q0KKUC74074317; Fri, 20 Jan 2012 20:30:12 GMT (envelope-from gnats) Resent-Date: Fri, 20 Jan 2012 20:30:12 GMT Resent-Message-Id: <201201202030.q0KKUC74074317@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Oliver Heesakkers Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D6B24106566B for ; Fri, 20 Jan 2012 20:26:30 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id C0C898FC08 for ; Fri, 20 Jan 2012 20:26:30 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q0KKQUbI028177 for ; Fri, 20 Jan 2012 20:26:30 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id q0KKQURL028176; Fri, 20 Jan 2012 20:26:30 GMT (envelope-from nobody) Message-Id: <201201202026.q0KKQURL028176@red.freebsd.org> Date: Fri, 20 Jan 2012 20:26:30 GMT From: Oliver Heesakkers To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/164344: [maintainer patch] astro/merkaartor: Don't use INSTALL_ICONS when Gnome not installed X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jan 2012 20:30:13 -0000 >Number: 164344 >Category: ports >Synopsis: [maintainer patch] astro/merkaartor: Don't use INSTALL_ICONS when Gnome not installed >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Jan 20 20:30:12 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Oliver Heesakkers >Release: 9.0-RELEASE #0 >Organization: >Environment: >Description: I recently became aware that INSTALL_ICONS is set in this port that I took over. INSTALL_ICONS appears to be a very Gnome-specific instruction to ensure icons appear in Gnome's menu. Setting INSTALL_ICONS pulls in a lot of Gnome-specific ports that are not necessary for the correct functioning of Merkaartor. Ofcourse, if you do use Gnome, setting this would be desirable, so I set INSTALL_ICONS if ${LOCALBASE}/bin/gnome-session is present on the system I don't know why the diff-output touches the boost line, but it doesn't look to hurt either. >How-To-Repeat: Start in an empty FreeBSD environment, start the Merkaartor build and watch it pull in a lot of gnome stuff >Fix: diff -ruN merkaartor.orig/Makefile merkaartor/Makefile --- merkaartor.orig/Makefile 2012-01-20 21:10:31.000000000 +0100 +++ merkaartor/Makefile 2012-01-20 21:11:16.000000000 +0100 @@ -14,10 +14,10 @@ MAINTAINER= dev2@heesakkers.info COMMENT= An openstreetmap mapping program -BUILD_DEPENDS= ${LOCALBASE}/include/boost/concept_check.hpp:${PORTSDIR}/devel/boost-libs - LICENSE= GPLv2 +BUILD_DEPENDS= ${LOCALBASE}/include/boost/concept_check.hpp:${PORTSDIR}/devel/boost-libs + USE_BZIP2= yes USE_LDCONFIG= yes @@ -25,7 +25,10 @@ QT_COMPONENTS= qmake_build uic_build moc_build rcc_build \ gui network svg webkit xml imageformats script scripttools MAKE_JOBS_SAFE= yes + +.if exists(${LOCALBASE}/bin/gnome-session) INSTALLS_ICONS= yes +.endif QMAKEFLAGS= PREFIX=${PREFIX} >Release-Note: >Audit-Trail: >Unformatted: