Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 28 Jul 2009 15:29:38 +0200
From:      Pawel Jakub Dawidek <pjd@FreeBSD.org>
To:        freebsd-rc@FreeBSD.org
Subject:   Review request.
Message-ID:  <20090728132938.GG1690@garage.freebsd.pl>

next in thread | raw e-mail | index | archive | help

--gvF4niNJ+uBMJnEh
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi.

I'm looking for a review of the following:

Currently there is a problem with fscking UFS file systems created on
top of ZVOLs. The problem is that rc.d/fsck runs before rc.d/zfs. The
latter makes ZVOLs to appear in /dev/. In such case rc.d/fsck cannot
find devfs entry and aborts. We cannot simply move rc.d/zfs before
rc.d/fsck, because we first want kern.hostid to be configured (by
rc.d/hostid). If we won't wait (hostid will be 0) we can reuse disks
which are in use by different systems (eg. in SAN/NAS environment).
We also cannot move rc.d/hostid before rc.d/fsck, because rc.d/hostid on
first system start stores generated kern.hostuuid in /etc/hostid file,
so it needs root file system to be mounted read-write.
 =20
My fix is to split rc.d/hostid so that rc.d/hostid (which will now run
before rc.d/fsck) only generates hostid and sets up sysctls, but doesn't
touch root file system and rc.d/hostid_save (which is run after
rc.d/root) and only creates /etc/hostid file.
 =20
With that in place, I can move ZVOL initialization to dedicated
rc.d/zvol script which runs before rc.d/fsck.

The patch is here:

	http://people.freebsd.org/~pjd/patches/zvol_fsck.patch
 =20
--=20
Pawel Jakub Dawidek                       http://www.wheel.pl
pjd@FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!

--gvF4niNJ+uBMJnEh
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.4 (FreeBSD)

iD8DBQFKbv1CForvXbEpPzQRAryyAKDcRduXC+oXt0wIrYnlIOQyMZdMnQCgszeH
Qe+W1c2Kf9JTIS5A0UX7hgg=
=1xuL
-----END PGP SIGNATURE-----

--gvF4niNJ+uBMJnEh--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090728132938.GG1690>