From owner-freebsd-current@freebsd.org Tue Jul 9 05:04:03 2019 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5B9CC15CF255 for ; Tue, 9 Jul 2019 05:04:03 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "troutmask", Issuer "troutmask" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 26F4F768D6; Tue, 9 Jul 2019 05:04:02 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id x69540Gm063326 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Mon, 8 Jul 2019 22:04:00 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id x69540Ii063325; Mon, 8 Jul 2019 22:04:00 -0700 (PDT) (envelope-from sgk) Date: Mon, 8 Jul 2019 22:04:00 -0700 From: Steve Kargl To: freebsd-current@freebsd.org Cc: markj@freebsd.org Subject: Re: vm_page_hold() and drm-legacy-kmod Message-ID: <20190709050400.GA63317@troutmask.apl.washington.edu> Reply-To: sgk@troutmask.apl.washington.edu References: <20190709043058.GA63004@troutmask.apl.washington.edu> <20190709043505.GC63004@troutmask.apl.washington.edu> <20190709044336.GA63186@troutmask.apl.washington.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190709044336.GA63186@troutmask.apl.washington.edu> User-Agent: Mutt/1.11.4 (2019-03-13) X-Rspamd-Queue-Id: 26F4F768D6 X-Spamd-Bar: ++ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [2.58 / 15.00]; ARC_NA(0.00)[]; HAS_REPLYTO(0.00)[sgk@troutmask.apl.washington.edu]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_SPAM_SHORT(0.95)[0.954,0]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; DMARC_NA(0.00)[washington.edu]; AUTH_NA(1.00)[]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; RCVD_TLS_LAST(0.00)[]; MX_GOOD(-0.01)[cached: troutmask.apl.washington.edu]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_SPAM_LONG(0.18)[0.180,0]; NEURAL_SPAM_MEDIUM(0.57)[0.571,0]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:73, ipnet:128.95.0.0/16, country:US]; MID_RHS_MATCH_FROM(0.00)[]; IP_SCORE(-0.01)[ip: (0.07), ipnet: 128.95.0.0/16(0.06), asn: 73(-0.14), country: US(-0.06)] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jul 2019 05:04:03 -0000 On Mon, Jul 08, 2019 at 09:43:36PM -0700, Steve Kargl wrote: > On Mon, Jul 08, 2019 at 09:35:05PM -0700, Steve Kargl wrote: > > On Mon, Jul 08, 2019 at 09:31:12PM -0700, Steve Kargl wrote: > > > It seems the recent flurry of vm commits has > > > broken the graphics/drm-legacy-kmod port. > > > vm_page_hold() no longer exists. How do I > > > fix the port? > > > > > > > Whoops. The missing function is vm_page_unhold(). > > Anywhoo, how do I fix this? > > > The code in question is > > for (i = 0; i < vsg->num_pages; i++) { > m = vsg->pages[i]; > vm_page_lock(m); > vm_page_wire(m); > vm_page_unhold(m); > vm_page_unlock(m); > } This was broken by r349846 committed by markj. -- Steve