Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 22 Jan 2014 20:39:02 GMT
From:      nemysis <nemysis@FreeBSD.org>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/186018: [PATCH] multimedia/smplayer Add missing dependency, DOCS Option
Message-ID:  <201401222039.s0MKd2KS053797@oldred.freebsd.org>
Resent-Message-ID: <201401222040.s0MKe0wK064789@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         186018
>Category:       ports
>Synopsis:       [PATCH] multimedia/smplayer Add missing dependency, DOCS Option
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jan 22 20:40:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     nemysis
>Release:        FreeBSD 9.2-RELEASE amd64
>Organization:
>Environment:
FreeBSD 9.2-RELEASE-p8 FreeBSD 9.2-RELEASE-p8 #0: Mon Sep 23 16:26:45 UTC 2013
>Description:
- Bump PORTREVISION for dependency change
- Add dependency for multimedia/smplayer-skins
- Add DOCS Option
- Add pkg-message about multimedia/smtube
- Strip executable
>How-To-Repeat:

>Fix:
Apply enclosed smplayer.diff

Patch attached with submission follows:

Index: Makefile
===================================================================
--- Makefile	(revision 340715)
+++ Makefile	(working copy)
@@ -3,6 +3,7 @@
 
 PORTNAME=	smplayer
 DISTVERSION=	0.8.6
+PORTREVISION=	1
 CATEGORIES=	multimedia audio kde
 MASTER_SITES=	SF/${PORTNAME}/SMPlayer/${PORTVERSION}
 
@@ -10,6 +11,7 @@
 COMMENT=	Complete front-end based on Qt4 for mplayer
 
 RUN_DEPENDS=	mplayer:${PORTSDIR}/multimedia/mplayer \
+		${LOCALBASE}/share/smplayer/themes:${PORTSDIR}/multimedia/smplayer-skins \
 		${LOCALBASE}/share/smplayer/themes:${PORTSDIR}/multimedia/smplayer-themes
 
 USE_QT4=	gui network script xml moc_build rcc_build uic_build \
@@ -26,6 +28,10 @@
 PORTDOCS=	Changelog Copying.txt Install.txt Not_so_obvious_things.txt \
 		Readme.txt Release_notes.txt
 
+OPTIONS_DEFINE=	DOCS
+
+SUB_FILES=      pkg-message
+
 .include <bsd.port.options.mk>
 
 post-patch:
@@ -36,9 +42,9 @@
 		${WRKSRC}/Makefile
 
 post-install:
-.if ${PORT_OPTIONS:MDOCS}
+	${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/${PORTNAME}
+
 	@${MKDIR} ${STAGEDIR}${DOCSDIR}
-	${INSTALL_DATA} ${PORTDOCS:S,^,${WRKSRC}/,} ${STAGEDIR}${DOCSDIR}
-.endif
+	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${STAGEDIR}${DOCSDIR}
 
 .include <bsd.port.mk>
Index: files/pkg-message.in
===================================================================
--- files/pkg-message.in	(revision 0)
+++ files/pkg-message.in	(working copy)
@@ -0,0 +1,7 @@
+===============================================================================
+
+SMPlayer has been installed.
+
+For Youtube Videos please use multimedia/smtube port.
+
+===============================================================================

Property changes on: files/pkg-message.in
___________________________________________________________________
Added: svn:mime-type
## -0,0 +1 ##
+text/plain
\ No newline at end of property
Added: fbsd:nokeywords
## -0,0 +1 ##
+yes
\ No newline at end of property
Added: svn:eol-style
## -0,0 +1 ##
+native
\ No newline at end of property


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201401222039.s0MKd2KS053797>