From owner-svn-src-all@freebsd.org Fri Aug 12 19:35:47 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CF548BB3966; Fri, 12 Aug 2016 19:35:47 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E6F5F1B0C; Fri, 12 Aug 2016 19:35:45 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id u7CJZdYr043389 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Fri, 12 Aug 2016 22:35:39 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua u7CJZdYr043389 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id u7CJZdFS043388; Fri, 12 Aug 2016 22:35:39 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 12 Aug 2016 22:35:39 +0300 From: Konstantin Belousov To: Ed Schouten Cc: Ngie Cooper , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r304011 - head/libexec/rtld-elf Message-ID: <20160812193539.GR83214@kib.kiev.ua> References: <201608121829.u7CITCIu059447@repo.freebsd.org> <35B0B56E-A536-4A07-B397-7E5ABAB4CB34@gmail.com> <20160812183636.GP83214@kib.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.1 (2016-04-27) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Aug 2016 19:35:47 -0000 On Fri, Aug 12, 2016 at 09:32:37PM +0200, Ed Schouten wrote: > 2016-08-12 20:36 GMT+02:00 Konstantin Belousov : > > Because the API is unusable. It causes full queue iteration when the object > > is NULL, i.e. at the end of the queue, instead of doing nothing. > > Ah, thanks for working on this then. I personally think that all of > those macros in that run in linear time should be > removed. Why not just use the proper data structure? What is improper about the tail-queue for global object list ? Typical operations with it involve all objects in the list. The only special ops I am aware are lookups by name or by dev_t/inode, but having the parallel (two) maps there is overkill.