From owner-cvs-src@FreeBSD.ORG Sat Nov 15 15:10:48 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AC4F116A4CF for ; Sat, 15 Nov 2003 15:10:48 -0800 (PST) Received: from mailtoaster1.pipeline.ch (mailtoaster1.pipeline.ch [62.48.0.70]) by mx1.FreeBSD.org (Postfix) with ESMTP id CD44843FBF for ; Sat, 15 Nov 2003 15:10:45 -0800 (PST) (envelope-from oppermann@pipeline.ch) Received: (qmail 24107 invoked from network); 15 Nov 2003 23:13:41 -0000 Received: from unknown (HELO pipeline.ch) ([195.134.148.7]) (envelope-sender ) by mailtoaster1.pipeline.ch (qmail-ldap-1.03) with SMTP for ; 15 Nov 2003 23:13:41 -0000 Message-ID: <3FB6B273.50EB48BC@pipeline.ch> Date: Sun, 16 Nov 2003 00:10:43 +0100 From: Andre Oppermann X-Mailer: Mozilla 4.76 [en] (Windows NT 5.0; U) X-Accept-Language: en MIME-Version: 1.0 To: Nate Lawson References: <20031115170411.6330416A4E9@hub.freebsd.org> <20031115121034.K54473@root.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet ip_fastfwd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Nov 2003 23:10:48 -0000 Nate Lawson wrote: > > On Sat, 15 Nov 2003, Andre Oppermann wrote: > > Modified files: > > sys/netinet ip_fastfwd.c > > Log: > > Correct a cast to make it compile on 64bit platforms (noticed by tinderbox) > > and remove two unneccessary variable initializations. > > Make the introduction comment more clear with regard which parts of > > the packet are touched. > > > > Requested by: luigi > > > > Revision Changes Path > > 1.2 +6 -6 src/sys/netinet/ip_fastfwd.c > > > > --- src/sys/netinet/ip_fastfwd.c:1.1 Fri Nov 14 13:02:21 2003 > > +++ src/sys/netinet/ip_fastfwd.c Sat Nov 15 09:03:37 2003 > > @@ -567,7 +567,7 @@ > > goto drop; > > } > > tag->m_flags = PACKET_TAG_DIVERT; > > - tag->m_data = (caddr_t)(u_int32_t)args.divert_rule; > > + tag->m_data = (caddr_t)(u_long)args.divert_rule; > > tag->m_next = m; > > /* XXX: really bloody hack, see ip_input */ > > tag->m_nextpkt = (struct mbuf *)1; > > I believe this cast is still bogus. You want uintptr_t. Ok, I admit I'm no not yet fully used to all the types we have available in the kernel. And I try to avoid casting if ever possible in my code. I'll change it to that and test on my machine plus compile it on sledge (amd64). -- Andre