From owner-freebsd-ports@FreeBSD.ORG Mon Mar 14 00:45:52 2011 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2AE06106566B for ; Mon, 14 Mar 2011 00:45:52 +0000 (UTC) (envelope-from dougb@dougbarton.us) Received: from mail2.fluidhosting.com (mx22.fluidhosting.com [204.14.89.5]) by mx1.freebsd.org (Postfix) with ESMTP id CBD3C8FC14 for ; Mon, 14 Mar 2011 00:45:51 +0000 (UTC) Received: (qmail 1590 invoked by uid 399); 14 Mar 2011 00:45:47 -0000 Received: from router.ka9q.net (HELO ?192.168.2.9?) (dougb@dougbarton.us@75.60.237.91) by mail2.fluidhosting.com with ESMTPAM; 14 Mar 2011 00:45:47 -0000 X-Originating-IP: 75.60.237.91 X-Sender: dougb@dougbarton.us Message-ID: <4D7D653A.6090703@dougbarton.us> Date: Sun, 13 Mar 2011 17:45:46 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.15) Gecko/20110303 Thunderbird/3.1.9 MIME-Version: 1.0 To: Peter Jeremy References: <20110314003535.GC5392@server.vk2pj.dyndns.org> In-Reply-To: <20110314003535.GC5392@server.vk2pj.dyndns.org> X-Enigmail-Version: 1.1.1 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: ports@freebsd.org Subject: Re: portmaster comments X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Mar 2011 00:45:52 -0000 On 3/13/2011 5:35 PM, Peter Jeremy wrote: > Hi Doug, > > I'd like to raise a couple of nits with portmaster (primarily a wish > for more configurability): > > 1) In v3.0, you added code to nice(1) all make(1) invocations. In some > cases, the default niceness does not suit me (in particular, I'd often > prefer '0' to '10'). Would it be possible to add an option to control > the priority? > > 2) In v3.6, you added a "find $WRKDIRPREFIX ..." to the cleanup. For > various reasons, I have _lots_ of unrelated stuff under that tree and > so the find(1) takes an unacceptably long time to run. It would be > nice to restrict that search to $WRKDIRPREFIX${.CURDIR} and have an > option to disable it completely. Neither is likely to happen. :) I may however remove 1, it didn't really help much, if at all. As for 2, my suggestion is to have a WRKDIRPREFIX for development stuff, and a different one for portmaster. It's pretty easy to do with a make.conf knob searching for whether UPGRADE_TOOL is set to "portmaster." I have such a thing which I can send you if you really need me to, but I'm not booted into FreeBSD right now so I don't have it close to hand. BTW, the reason I'm not amenable to your suggestion in 2 is that only a few developer-types actually care about this, and that doesn't justify the code complexity. Just be thankful I didn't go with my first instinct, which was to 'rm -rf $WRKDIRPREFIX' :) hth, Doug -- Nothin' ever doesn't change, but nothin' changes much. -- OK Go Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/