From owner-freebsd-net@FreeBSD.ORG  Thu Jan 22 23:05:08 2009
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7A186106564A;
	Thu, 22 Jan 2009 23:05:08 +0000 (UTC)
	(envelope-from bzeeb-lists@lists.zabbadoz.net)
Received: from mail.cksoft.de (mail.cksoft.de [62.111.66.27])
	by mx1.freebsd.org (Postfix) with ESMTP id 2BAC88FC1E;
	Thu, 22 Jan 2009 23:05:08 +0000 (UTC)
	(envelope-from bzeeb-lists@lists.zabbadoz.net)
Received: from localhost (amavis.str.cksoft.de [192.168.74.71])
	by mail.cksoft.de (Postfix) with ESMTP id A0BDA41C74D;
	Fri, 23 Jan 2009 00:05:05 +0100 (CET)
X-Virus-Scanned: amavisd-new at cksoft.de
Received: from mail.cksoft.de ([62.111.66.27])
	by localhost (amavis.str.cksoft.de [192.168.74.71]) (amavisd-new,
	port 10024)
	with ESMTP id GjaNIKfF+WPO; Fri, 23 Jan 2009 00:05:05 +0100 (CET)
Received: by mail.cksoft.de (Postfix, from userid 66)
	id 3A0B841C650; Fri, 23 Jan 2009 00:05:05 +0100 (CET)
Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net
	[10.111.66.10])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mail.int.zabbadoz.net (Postfix) with ESMTP id D4EB84448D5;
	Thu, 22 Jan 2009 23:03:02 +0000 (UTC)
Date: Thu, 22 Jan 2009 23:03:02 +0000 (UTC)
From: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>
X-X-Sender: bz@maildrop.int.zabbadoz.net
To: FreeBSD current mailing list <current@freebsd.org>
Message-ID: <20090122225404.U45399@maildrop.int.zabbadoz.net>
X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: FreeBSD net mailing list <net@freebsd.org>
Subject: Need testers for a network cleanup patch
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Jan 2009 23:05:09 -0000

Hi,

while cleaning up protosw things I found that rip6_output was most
likely never called from pr_output and after a short talk with Robert
the conclusion was that the same had been true for rip_output.

Before I am going to remove the initializations I made the two
rip{,6}_output functions calling panic().

I have a patch for HEAD here:
http://people.freebsd.org/~bz/20090122-03-pr_output.diff

and one for 7-STABLE here (compiled but not booted):
http://people.freebsd.org/~bz/20090122-04-pr_output-7STABLE.diff


I am confident it will not panic (at least for HEAD;) but not 100%
sure so you can run this on your test or devel machine but I'd not
run it on a production machine.

If you are going to use the 7-STABLE patch make sure to have debugging
support in your kernel as well so we could get backtraces in the
unlikely event of panic.


Please reply directly to me if you have (un)successfully run the
patch and do NOT to the lists.
In case you think you run it successfully mail me after a
2-3 days, and _not_ with an "it booted" message! ;-)


Thanks for your help.
/bz

-- 
Bjoern A. Zeeb                      The greatest risk is not taking one.