From owner-cvs-all Sat Sep 15 16:54:14 2001 Delivered-To: cvs-all@freebsd.org Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169]) by hub.freebsd.org (Postfix) with ESMTP id 21D3837B407; Sat, 15 Sep 2001 16:54:05 -0700 (PDT) Received: (from obrien@localhost) by dragon.nuxi.com (8.11.6/8.11.1) id f8FNs3c84091; Sat, 15 Sep 2001 16:54:03 -0700 (PDT) (envelope-from obrien) Date: Sat, 15 Sep 2001 16:54:02 -0700 From: "David O'Brien" To: Bruce Evans Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/man/man9 style.9 Message-ID: <20010915165402.A84034@dragon.nuxi.com> Reply-To: obrien@FreeBSD.org References: <20010915121926.A71700@dragon.nuxi.com> <20010916054620.T29957-100000@delplex.bde.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010916054620.T29957-100000@delplex.bde.org>; from bde@zeta.org.au on Sun, Sep 16, 2001 at 06:15:45AM +1000 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, Sep 16, 2001 at 06:15:45AM +1000, Bruce Evans wrote: > I now prefer something like: > > --- > > > #if 0 /* maybe change to #ifdef VENDOR_ID */ > > #endif > > #include > __FBSDID($NetBSD$) > --- Why do we need to "#if 0" out NetBSD's __RCSID's? Our macros handle them just fine. Thus we would only be adding __FBSDID() to such code. Is it OK to only comment out non-__RCSID using code? Doing it your way, adds more of our changes around possible Vendor code -- CVS will barf harder in the face of that. -- -- David (obrien@FreeBSD.org) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message