From owner-freebsd-sparc64@FreeBSD.ORG  Wed Jun 11 14:41:27 2003
Return-Path: <owner-freebsd-sparc64@FreeBSD.ORG>
Delivered-To: freebsd-sparc64@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 32D7D37B401; Wed, 11 Jun 2003 14:41:27 -0700 (PDT)
Received: from aslan.scsiguy.com (aslan.scsiguy.com [63.229.232.106])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 41A5D43FB1; Wed, 11 Jun 2003 14:41:26 -0700 (PDT)
	(envelope-from gibbs@scsiguy.com)
Received: from localhost (aslan.scsiguy.com [63.229.232.106])
	by aslan.scsiguy.com (8.12.9/8.12.8) with ESMTP id h5BLfNvl005247;
	Wed, 11 Jun 2003 15:41:24 -0600 (MDT)
	(envelope-from gibbs@scsiguy.com)
Date: Wed, 11 Jun 2003 15:41:24 -0600
From: "Justin T. Gibbs" <gibbs@scsiguy.com>
To: Thomas Moestl <t.moestl@tu-bs.de>,
	John-Mark Gurney <gurney_j@resnet.uoregon.edu>
Message-ID: <385060000.1055367683@caspian.scsiguy.com>
In-Reply-To: <20030610112458.GA734@crow.dom2ip.de>
References: <20030609165838.32044@hydrogen.funkthat.com>
	<20030610112458.GA734@crow.dom2ip.de>
X-Mailer: Mulberry/3.0.3 (Linux/x86)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
cc: freebsd-current@freebsd.org
cc: freebsd-sparc64@freebsd.org
Subject: Re: PCI bus numbering and orphaned devices
X-BeenThere: freebsd-sparc64@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: "Justin T. Gibbs" <gibbs@scsiguy.com>
List-Id: Porting FreeBSD to the Sparc <freebsd-sparc64.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-sparc64>,
	<mailto:freebsd-sparc64-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-sparc64>
List-Post: <mailto:freebsd-sparc64@freebsd.org>
List-Help: <mailto:freebsd-sparc64-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-sparc64>,
	<mailto:freebsd-sparc64-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Jun 2003 21:41:27 -0000

>> +	 *
>> +	 * If we don't hardware the bus down, pciconf gets confused.
>>  	 */
>>  	if (sc->secbus != 0) {
>> -		child = device_add_child(dev, "pci", -1);
>> +		child = device_add_child(dev, "pci", sc->secbus);
>>  		if (child != NULL)
>>  			return (bus_generic_attach(dev));
>>  	} else
>
> This one looks good, please commit. The comment above is outdated, so
> it might be better to just remove it completely.

At least fix the typo in the comment if you aren't going to remove it.

--
Justin