Date: Tue, 27 Jan 2009 21:48:47 +0000 (UTC) From: Robert Watson <rwatson@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/sys/ufs/ffs ffs_alloc.c ffs_balloc.c ffs_extern.h ffs_inode.c ffs_vnops.c Message-ID: <200901272149.n0RLn5X0098065@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
rwatson 2009-01-27 21:48:47 UTC FreeBSD src repository Modified files: sys/ufs/ffs ffs_alloc.c ffs_balloc.c ffs_extern.h ffs_inode.c ffs_vnops.c Log: SVN rev 187790 on 2009-01-27 21:48:47Z by rwatson Following a fair amount of real world experience with ACLs and extended attributes since FreeBSD 5, make the following semantic changes: - Don't update the inode modification time (mtime) when extended attributes (and hence also ACLs) are added, modified, or removed. - Don't update the inode access tie (atime) when extended attributes (and hence also ACLs) are queried. This means that rsync (and related tools) won't improperly think that the data in the file has changed when only the ACL has changed. Note that ffs_reallocblks() has not been changed to not update on an IO_EXT transaction, but currently EAs don't use the cluster write routines so this shouldn't be a problem. If EAs grow support for clustering, then VOP_REALLOCBLKS() will need to grow a flag argument to carry down IO_EXT to UFS. MFC after: 1 week PR: ports/125739 Reported by: Alexander Zagrebin <alexz@visp.ru> Tested by: pluknet <pluknet@gmail.com>, Greg Byshenk <freebsd@byshenk.net> Discussed with: kib, kientzle, timur, Alexander Bokovoy <ab@samba.org> Revision Changes Path 1.151 +16 -7 src/sys/ufs/ffs/ffs_alloc.c 1.55 +23 -19 src/sys/ufs/ffs/ffs_balloc.c 1.78 +3 -3 src/sys/ufs/ffs/ffs_extern.h 1.117 +1 -1 src/sys/ufs/ffs/ffs_inode.c 1.186 +1 -9 src/sys/ufs/ffs/ffs_vnops.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200901272149.n0RLn5X0098065>