From owner-freebsd-current@FreeBSD.ORG  Tue Jan 15 23:10:51 2013
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id 877EECFA;
 Tue, 15 Jan 2013 23:10:51 +0000 (UTC)
 (envelope-from jmg@h2.funkthat.com)
Received: from h2.funkthat.com (gate2.funkthat.com [208.87.223.18])
 by mx1.freebsd.org (Postfix) with ESMTP id 5D08C10A;
 Tue, 15 Jan 2013 23:10:51 +0000 (UTC)
Received: from h2.funkthat.com (localhost [127.0.0.1])
 by h2.funkthat.com (8.14.3/8.14.3) with ESMTP id r0FNAmTR047279
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
 Tue, 15 Jan 2013 15:10:48 -0800 (PST)
 (envelope-from jmg@h2.funkthat.com)
Received: (from jmg@localhost)
 by h2.funkthat.com (8.14.3/8.14.3/Submit) id r0FNAlC9047278;
 Tue, 15 Jan 2013 15:10:47 -0800 (PST) (envelope-from jmg)
Date: Tue, 15 Jan 2013 15:10:47 -0800
From: John-Mark Gurney <jmg@funkthat.com>
To: hiren panchasara <hiren.panchasara@gmail.com>
Subject: Re: Clang warning patches
Message-ID: <20130115231047.GD1410@funkthat.com>
Mail-Followup-To: hiren panchasara <hiren.panchasara@gmail.com>,
 freebsd-current <freebsd-current@freebsd.org>, sbruno@freebsd.org
References: <CALCpEUEEPJFhrJMBii-3HHGsK3VUYgfgsh5cfGiC1ZsgWPDhPg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CALCpEUEEPJFhrJMBii-3HHGsK3VUYgfgsh5cfGiC1ZsgWPDhPg@mail.gmail.com>
User-Agent: Mutt/1.4.2.3i
X-Operating-System: FreeBSD 7.2-RELEASE i386
X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88  9322 9CB1 8F74 6D3F A396
X-Files: The truth is out there
X-URL: http://resnet.uoregon.edu/~gurney_j/
X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html
X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger?
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.2
 (h2.funkthat.com [127.0.0.1]); Tue, 15 Jan 2013 15:10:48 -0800 (PST)
Cc: freebsd-current <freebsd-current@freebsd.org>
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Jan 2013 23:10:51 -0000

hiren panchasara wrote this message on Tue, Jan 15, 2013 at 07:52 -0800:
> http://www.strugglingcoder.info/patches/clang_warnings_dev_bktr.txt

This patch does not look correct at all...  It is simply removing code..

How is is good that after we failed to set the tv_freq that we continue
on?

What is the warning that we are fixing here?

-- 
  John-Mark Gurney				Voice: +1 415 225 5579

     "All that I will do, has been done, All that I have, has not."