From owner-freebsd-ports@FreeBSD.ORG Sat Jun 9 19:12:49 2012 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AB5E9106566C for ; Sat, 9 Jun 2012 19:12:49 +0000 (UTC) (envelope-from kob6558@gmail.com) Received: from mail-we0-f182.google.com (mail-we0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id 348578FC0C for ; Sat, 9 Jun 2012 19:12:49 +0000 (UTC) Received: by werg1 with SMTP id g1so1579962wer.13 for ; Sat, 09 Jun 2012 12:12:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=HkToic5j2PIkPOFscXPxO4EEk7Nq4XjK8vand1rQtSk=; b=ILx9PM01/e3puDajPB/pSN1o94FxnW+S/v78GEKeRUMWHkS3jGVW0hA1zCjyh7XSUR 3J3F6HUcyxBVO3tDFSkbACgdW3GrGH+fhFG8wjmBPBQ9Uqaca36480134/n07cx6gCJB kIO+NR6CG7l1ltkkVJO6Ky2+oN8XPYcojX+bx3pMMuUbFQ/yi6cLVPq3IiuMlWQXfUdw rnm1jW2FXIcMULougALnrbG6FHaGQZwql+fEeAbZdxRJyWplPmx9lb6YgqZQk1fxyYI+ AbjWKe+dOxNRBNwBi5eA0Kh6vU/2HBmxlJ7jgtYzSRo8+p4dJXBjbim47M70ng/usAoq 0X/Q== MIME-Version: 1.0 Received: by 10.180.79.166 with SMTP id k6mr9371877wix.8.1339269168139; Sat, 09 Jun 2012 12:12:48 -0700 (PDT) Sender: kob6558@gmail.com Received: by 10.223.155.4 with HTTP; Sat, 9 Jun 2012 12:12:48 -0700 (PDT) In-Reply-To: <4FD39BE0.9080004@infracaninophile.co.uk> References: <4FD39BE0.9080004@infracaninophile.co.uk> Date: Sat, 9 Jun 2012 12:12:48 -0700 X-Google-Sender-Auth: CLUeUmxLiuvIYKWf_Hd02H_mQ-k Message-ID: From: Kevin Oberman To: Matthew Seaman Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: FreeBSD Ports ML , Chris Rees Subject: Re: Firefox and firefox-remote options issues X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Jun 2012 19:12:49 -0000 On Sat, Jun 9, 2012 at 11:54 AM, Matthew Seaman wrote: > On 09/06/2012 17:02, Kevin Oberman wrote: >> Wow! Not what I expected to find! >> >> Yes, /var/db/ports/firefox/options is there, but >> /var/db/ports/firefox-remote/options is not. And, when I look at >> /var/db/ports/firefox/options, it actually contains the options for >> firefox-remote! >> >> If I go into www/firefox and make config, >> /var/db/ports/firefox-remote/options contains the right options. Ouch. >> >> I'll need to re-build firefox-remote later, but at least I now expect >> firefox to build as I want it to. Something in parsing the port name >> seems to have been broken. > > That looks to be an accident. =A0Both those ports share the same options = file: > > % cd /usr/ports > % make -C www/firefox -V OPTIONSFILE > /var/db/ports/firefox/options > % make -C www/firefox-remote -V OPTIONSFILE > /var/db/ports/firefox/options > > Ultimately this is because both those ports have PORTNAME=3Dfirefox, whic= h > means both of them end up with the same UNIQUENAME, which is clearly a > bit contrary to the intent of that variable. > > This would have been the case even before OPTIONSng -- the location > where options would be stored hasn't changed. =A0However, firefox-remote > doesn't set any options of its own, so previously it wouldn't have used > its options file at all. =A0One of the effects of OPTIONSng is that every > port technically now uses options so would now use an options file. =A0So > collisions like this are going to show up. > > However, not all ports sharing OPTIONSFILEs are accidental. =A0For > instance Postgresql ports all use a shared file quite deliberately. > > Attached is a list of all the ports with a non-unique UNIQUENAME setting. Ahh. If I'd had some time, I suspect I would have spotted it. I am amazed that it has never bitten me in the past as I have had this port installed for over a decade. Of course, it would not have shown up using portupgrade, but portmaster does show it as it queries for options for all ports to be built BEFORE it starts building. I guess I never noticed that firefox-remote always asks for options but was seldom rebuilt while firefox is built frequently, but I guess I've never done a system where both were installed by portmaster in a single operation. Thanks. I'll drop the maintainer of firefox-remote a note open a PR on it. R. Kevin Oberman - Network Engineer rkoberman@gmail.com