From owner-svn-src-all@freebsd.org Sat Oct 31 20:57:12 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CF0BA4567C9; Sat, 31 Oct 2020 20:57:12 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CNs1h3cwPz3yZK; Sat, 31 Oct 2020 20:57:12 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-wr1-x434.google.com with SMTP id x7so10188572wrl.3; Sat, 31 Oct 2020 13:57:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=VoaopnFWGuziRYsB8y1pt5mGALVOeaXu1YSdaMTQX6Q=; b=T6pulWlkZ4Xj73tB/WFpzWRAbSxAjNmcldWYo+07yFmFk78CBUTzoMt52xR3vkf/S2 /8jz5WD+gBdDZ8PzhExX1LS4d+5Z33EJGMtWe0kYH1vmLvrQC9mNGdVYXXZcD6W5wNPO 80OP+HO+5aL9OPxcKv2eHn3ou2L0uICUY35uVzCcP+uTJxWRccfjVSl5u+TjyZCTQAYA V3u6dcW8YkD73oy7TtL67MF7dPjNZ1Cbiljk0nzDH5d7d9XKekW0aesPPOuP/g5Vxgjw tVlzizyduhY4ZwymJw00DMUEteYSPGTq0/RKaRgZw55ldjFjf3AFDSD0D7URpvld3APh hL6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=VoaopnFWGuziRYsB8y1pt5mGALVOeaXu1YSdaMTQX6Q=; b=UPYtpo9Of/xNkrldukVuvxVRK7ISw2GlnT/J3PWuQlLARBiDqDYPHiZ1uvsOoYIJre qBk8tq0ZfzNX7dYihHhFLos8cLM8W4Q9PPCuJsDD9g3J1SBV/z7K+AMeBuacrKtnKisr zEtDTvTI5ZVQ7YZQ23q12uUdUYXM5h1EW7ymNI8UW3JFdpRMtess1eGlrHmB22mfDqsK ipwoS5VPU2eRIavpRI5c6cX1Dk0KWrMmKn/l3zWwot6PR9yMbnffHhYhOxMRcwHxzu6V wZr8Iqoa8QN44GjL67IdOGqAvKOhir+X3PsH+zUxIHMuTRvrnFiPuovkLC1QTbvZ1W56 nBXA== X-Gm-Message-State: AOAM530p5kHUzhv4RAkRjTr2K6cnIfXo3LOelJ1z7fedLnq9wvsdzkPI NJEB/FaSool8MzDHhk3so+ZlWjAqG9XQRTS3DOhwe9OhCR8= X-Google-Smtp-Source: ABdhPJyCnQ0j7BLmbgFYsM9DbxJ/7Dq7gFnpGwi7Y1Nfm8mcNHF09/zof8ZYJFAnHSnLT0MuVDXu49YMao9uyqZBVIQ= X-Received: by 2002:a5d:4cd1:: with SMTP id c17mr11297229wrt.109.1604177830150; Sat, 31 Oct 2020 13:57:10 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a5d:4c4f:0:0:0:0:0 with HTTP; Sat, 31 Oct 2020 13:57:09 -0700 (PDT) In-Reply-To: References: <202010311907.09VJ7WcY036325@repo.freebsd.org> <7b9e157c-9b8e-4a0e-b3f6-38edbfebf005@www.fastmail.com> <540675c8-35bb-40a7-b947-73f31a72bff2@www.fastmail.com> From: Mateusz Guzik Date: Sat, 31 Oct 2020 21:57:09 +0100 Message-ID: Subject: Re: svn commit: r367229 - in head/sys/contrib/openzfs: include/sys/zstd module/zstd To: Brandon Bergren Cc: Brandon Bergren , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4CNs1h3cwPz3yZK X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Oct 2020 20:57:12 -0000 I agree. Please commit. On 10/31/20, Brandon Bergren wrote: > Yeah, that is what was happening. The minimal implementation needed for > libsa was missing. > > On Sat, Oct 31, 2020, at 3:33 PM, Brandon Bergren wrote: >> Maybe this is it?: >> >> Index: sys/contrib/openzfs/include/os/freebsd/spl/sys/atomic.h >> =================================================================== >> --- sys/contrib/openzfs/include/os/freebsd/spl/sys/atomic.h (revision >> 367230) >> +++ sys/contrib/openzfs/include/os/freebsd/spl/sys/atomic.h (working >> copy) >> @@ -188,6 +188,8 @@ >> */ >> #undef atomic_add_64 >> #define atomic_add_64(ptr, val) *(ptr) += val >> +#undef atomic_sub_64 >> +#define atomic_sub_64(ptr, val) *(ptr) -= val >> #endif /* !_STANDALONE */ >> >> #endif /* !_OPENSOLARIS_SYS_ATOMIC_H_ */ >> >> >> Note that there is also another build failure in the tree at the moment. >> >> On Sat, Oct 31, 2020, at 3:25 PM, Brandon Bergren wrote: >> > Actually, looking at it again, it looks like the spl header is doing it >> > >> > wrong and not providing a fallback for atomic_sub_64, it's just >> > defining it to atomic_subtract_64 and assuming that exists. >> > >> > On Sat, Oct 31, 2020, at 3:23 PM, Mateusz Guzik wrote: >> > > Yep, jenkins told me. Working on it. >> > > >> > > On 10/31/20, Brandon Bergren wrote: >> > > > This doesn't compile on platforms such as powerpc without pulling in >> > > > the >> > > > opensolaris atomics header from the spl that does locking emulation >> > > > of 64 >> > > > bit atomics, as platforms that don't have native 64 bit atomics do >> > > > not >> > > > provide them in the system header. >> > >> >> -- >> Brandon Bergren >> bdragon@imap.cc >> > > -- > Brandon Bergren > bdragon@FreeBSD.org > -- Mateusz Guzik