From owner-svn-src-all@freebsd.org Wed Mar 14 17:08:29 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2D584F2B64A; Wed, 14 Mar 2018 17:08:29 +0000 (UTC) (envelope-from rpokala@mac.com) Received: from pv33p00im-asmtp001.me.com (pv33p00im-asmtp001.me.com [17.142.194.250]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B86B36B818; Wed, 14 Mar 2018 17:08:28 +0000 (UTC) (envelope-from rpokala@mac.com) Received: from process-dkim-sign-daemon.pv33p00im-asmtp001.me.com by pv33p00im-asmtp001.me.com (Oracle Communications Messaging Server 8.0.1.2.20170607 64bit (built Jun 7 2017)) id <0P5L00900BCHI700@pv33p00im-asmtp001.me.com>; Wed, 14 Mar 2018 17:08:17 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mac.com; s=04042017; t=1521047297; bh=TAXoB+StXcej1KkQol0X9tJkrakNsRmANZ096y7v8Nw=; h=Date:Subject:From:To:Message-id:MIME-version:Content-type; b=hCRjya7ZjDNpunqNuKMjXt0X/C4GzVY6Uud2kaBuebx4bIlIor8iMK409YypIlzlV P5O1SN4cHrKDvEvbrCQuQ8ikeh3Q4GZpHqJXbc00mnflGR9AUsLl6o/7z5+3YU0v0h /NjABRr586oq2P1DIT0gBARBODs6MuWQHvFvOjtu8MKq2VIIACHtdRDZLHEIVNZXPq WzAgElIIUy/2eQpbEpirndNzDCCqOGqJ5Afl/MHOVrhicATH8bkC1wybcW1rN80N4n RwYtM6rv4COGMrnvLsgNAXo4zm6x2vqeZt2LZsfqRJXmAKudJbLQpDT2prYKILBBXb wQWRbrLofi56g== Received: from icloud.com ([127.0.0.1]) by pv33p00im-asmtp001.me.com (Oracle Communications Messaging Server 8.0.1.2.20170607 64bit (built Jun 7 2017)) with ESMTPSA id <0P5L00OKUBLQ4330@pv33p00im-asmtp001.me.com>; Wed, 14 Mar 2018 17:08:15 +0000 (GMT) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-03-14_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 clxscore=1015 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1803140191 User-Agent: Microsoft-MacOutlook/10.a.0.180210 Date: Wed, 14 Mar 2018 10:08:13 -0700 Subject: Re: svn commit: r330932 - in head/sys: cam/nvme dev/nvme From: Ravi Pokala To: Warner Losh , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-id: <22796282-7844-4E9A-AC32-10B09822FD25@mac.com> Thread-topic: svn commit: r330932 - in head/sys: cam/nvme dev/nvme References: <201803141644.w2EGioti046140@repo.freebsd.org> In-reply-to: <201803141644.w2EGioti046140@repo.freebsd.org> MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: quoted-printable X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Mar 2018 17:08:29 -0000 Hi Warner, The TRIM command takes a buffer of range structures, and this change consol= idates multiple range structures into the buffer for a single TRIM command, = correct? Whereas the old functionality was to populate the buffer with a sin= gle range structure? So if we wanted to trim ranges [P..T], [A..E], [K..O], the old functionalit= y would be: TRIM:[P..T] ; TRIM:[A..E] ; TRIM:[K..O] The new functionality would be: TRIM:[P..T], [A..E], [K..O] Right? > + /* XXX -- Could collapse adjacent ranges, but we don't for now */ > + /* XXX -- Could limit based on total payload size */ And that future enhancement would make it: TRIM:[A..E], [K..T] Is that correct? Thanks, Ravi (rpokala@) =EF=BB=BF-----Original Message----- From: on behalf of Warner Losh Date: 2018-03-14, Wednesday at 09:44 To: , , Subject: svn commit: r330932 - in head/sys: cam/nvme dev/nvme > Author: imp > Date: Wed Mar 14 16:44:50 2018 > New Revision: 330932 > URL: https://svnweb.freebsd.org/changeset/base/330932 >=20 > Log: > Implement trim collapsing in nda > =20 > When multiple trims are in the queue, collapse them as much as > possible. At present, this usually results in only a few trims being > collapsed together, but more work on that will make it possible to do > hundreds (up to some configurable max). > =20 > Sponsored by: Netflix