From owner-freebsd-stable@FreeBSD.ORG Tue Mar 3 16:48:39 2009 Return-Path: Delivered-To: stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 90B65106567D for ; Tue, 3 Mar 2009 16:48:39 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx22.fluidhosting.com [204.14.89.5]) by mx1.freebsd.org (Postfix) with ESMTP id 238C08FC17 for ; Tue, 3 Mar 2009 16:48:39 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: (qmail 13595 invoked by uid 399); 3 Mar 2009 16:48:31 -0000 Received: from localhost (HELO ?192.168.0.24?) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 3 Mar 2009 16:48:31 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <49AD5F60.7040208@FreeBSD.org> Date: Tue, 03 Mar 2009 08:48:32 -0800 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 2.0.0.19 (Windows/20081209) MIME-Version: 1.0 To: Oliver Lehmann References: <20090302163843.cc66c55e.lehmann@ans-netz.de> <20090302202520.eaf09b15.lehmann@ans-netz.de> <9e20d71e0903021355i3ad66b8fx14bdc3b395e311a5@mail.gmail.com> <9e20d71e0903021410i26ca8088oc2de76009b2773d2@mail.gmail.com> <49AC5C66.70301@FreeBSD.org> <20090303065208.87200365.lehmann@ans-netz.de> In-Reply-To: <20090303065208.87200365.lehmann@ans-netz.de> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: ports@freebsd.org, stable@freebsd.org, Artis Caune Subject: Re: restart a script in etc/rc.d X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Mar 2009 16:48:41 -0000 Oliver Lehmann wrote: > Doug Barton wrote: > >> Artis Caune wrote: >>> There is logic error in bacula rc.d script. It should first set >>> default variables and only then use them. >>> pidfile="${bacula_fd_pidfile}" >>> : ${bacula_fd_pidfile="/var/run/bacula-fd.9102.pid"} >>> >>> If you don't set pidfile in rc.conf, pidfile is "" so it kills all bacula-fd's >> Yes, I tried to convince the OP to fix this, but he thought he had it >> covered, so I'm giving him the opportunity to prove me wrong. :) > > Yeah this did it - Its working now. > I thought you where just telling me that to have another pidfile for the > 2nd start script - I missed the point that it was empty for the first one > and because of that it is falling back to ps... > > I'll probably write a PR and commit it after aproval for PROVIDE and the > pidfile setting... Excellent. :) Doug -- This .signature sanitized for your protection