From owner-cvs-src@FreeBSD.ORG Mon May 21 11:48:13 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 72EB716A421; Mon, 21 May 2007 11:48:13 +0000 (UTC) (envelope-from rse@engelschall.com) Received: from visp1.engelschall.com (visp1.engelschall.com [195.30.6.144]) by mx1.freebsd.org (Postfix) with ESMTP id 2DDD813C469; Mon, 21 May 2007 11:48:13 +0000 (UTC) (envelope-from rse@engelschall.com) Received: by visp1.engelschall.com (Postfix, from userid 21100) id D716C1B44831; Mon, 21 May 2007 13:48:57 +0200 (CEST) X-DKIM: Sendmail DKIM Filter v0.5.2 visp1.engelschall.com D716C1B44831 Received: by en1.engelschall.com (Postfix, from userid 10000) id 214AF6D868; Mon, 21 May 2007 13:47:29 +0200 (CEST) Date: Mon, 21 May 2007 13:47:29 +0200 From: "Ralf S. Engelschall" To: "Ralf S. Engelschall" Message-ID: <20070521114728.GA1928@engelschall.com> References: <200705210822.l4L8Miog004013@repoman.freebsd.org> <20070521085750.GA2277@rogue.navcom.lan> <20070521104522.GA88769@engelschall.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070521104522.GA88769@engelschall.com> Organization: FreeBSD User-Agent: Mutt/1.5.15 OpenPKG/CURRENT (2007-04-06) Cc: cvs-src@FreeBSD.org, Mike Makonnen , src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc/rc.d hostid X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: "Ralf S. Engelschall" List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 May 2007 11:48:13 -0000 On Mon, May 21, 2007, Ralf S. Engelschall wrote: > On Mon, May 21, 2007, Mike Makonnen wrote: > > > On Mon, May 21, 2007 at 08:22:44AM +0000, Ralf S. Engelschall wrote: > > > rse 2007-05-21 08:22:44 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > etc/rc.d hostid > > > Log: > > > The standardized textual representation of UUIDs according to RFC 4122 > > > and ISO/IEC-9834-8:2005 is with LOWER-CASE hexadecimal characters only, > > > so translate the (usually upper-case and this way not conforming) > > > representation of the BIOS UUID when reading it. Also be more strict > > > about the valid characters in the textual representation by checking for > > > just the hexadecimal characters. > > > > tr(1) lives in /usr/bin, which may not be available when / (root) is > > mounted (it may live on a remotely mounted filesystem, for example). So, > > you can't rely on tr(1) being available when this script is run. > > Well, I explicitly checked the script and it contained uuidgen(1) which > also stays under /usr/bin so I blindly concluded that tr(1) is fine, too > ;-) So, although we can try to replace tr(1) with something else we have > a problem as we cannot easily replace the uuidgen(1) call. Hmmm... I'll > investigate. Thanks for the hint. Ok, checked again and now fixed. First, sorry for posting misinformation: uuidgen(1) already stays in /bin in CURRENT, of course. So this is no problem. And the tr(1) usage I've now replaced with an equivalent csh(1) usage. Not really nice but it was the best alternative I've found with the limited tools available in /bin. Thanks for catching this issue. -- rse@FreeBSD.org Ralf S. Engelschall FreeBSD.org/~rse rse@engelschall.com FreeBSD committer www.engelschall.com