From owner-svn-src-all@freebsd.org Thu Jun 18 00:44:12 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D810F33BE47; Thu, 18 Jun 2020 00:44:12 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49nNVM6CZfz3W36; Thu, 18 Jun 2020 00:44:11 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-ot1-f54.google.com with SMTP id n5so3215885otj.1; Wed, 17 Jun 2020 17:44:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc:content-transfer-encoding; bh=wwFs//PNYHIXgdtARsgzZxkmklJbP77AECsO2XD2fxo=; b=klLX+uHDgAtu2/iepk/XxJoYhp7TJnN0NaLjgDp5org6owPnYZfJNgSglMs8Gcw4rA V+97NA7r9QtH4BzONvkLZmg5cfLL/lOzcm2D5+wqi3mVkRYvYiozQ2S20MAQL0W7o7rU xzPb6a/hn2xZ97/DthO+jgA3Akij8+1JCwsNtL06DR/0VAEF6salOPZ2kXE1BEMypoLF MTUJZXQa2EZCtiyAntFcuSE0wT8NH+aWGkcFdSyg9DRSLry0tR/adnWbcPV5nSGk2TE4 YwM+cwETv1ZIKuwbnqd5VVX8bbhArbwxzhi6OdQyLHNp/FL5UJ+PxXCmB6zjSHNIfXfA RqLA== X-Gm-Message-State: AOAM531yFEYPNFSd2l3h6QnNRxq1elMPVloBUMQPflvG1euk9emsCkMc RrRi6qDCALzc1fEUQgJHEKgOMa4J X-Google-Smtp-Source: ABdhPJyBbnhE0pBX6OaLJqR3K6oJl7kL1/SjrYUd4XbGdNyBPDm94iapAqmPmHwsY2X1S7jGg18/eg== X-Received: by 2002:a05:6830:1391:: with SMTP id d17mr1554717otq.48.1592441049832; Wed, 17 Jun 2020 17:44:09 -0700 (PDT) Received: from mail-oo1-f45.google.com (mail-oo1-f45.google.com. [209.85.161.45]) by smtp.gmail.com with ESMTPSA id i2sm371040otp.77.2020.06.17.17.44.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Jun 2020 17:44:09 -0700 (PDT) Received: by mail-oo1-f45.google.com with SMTP id e12so822571oou.2; Wed, 17 Jun 2020 17:44:09 -0700 (PDT) X-Received: by 2002:a4a:d1ca:: with SMTP id a10mr1917238oos.31.1592441049466; Wed, 17 Jun 2020 17:44:09 -0700 (PDT) MIME-Version: 1.0 References: <202006162253.05GMruKi046200@repo.freebsd.org> <20200617110419.GF45690@kib.kiev.ua> In-Reply-To: <20200617110419.GF45690@kib.kiev.ua> Reply-To: cem@freebsd.org From: Conrad Meyer Date: Wed, 17 Jun 2020 17:43:58 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r362253 - head/sys/vm To: Konstantin Belousov Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 49nNVM6CZfz3W36 X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of csecem@gmail.com designates 209.85.210.54 as permitted sender) smtp.mailfrom=csecem@gmail.com X-Spamd-Result: default: False [-1.67 / 15.00]; HAS_REPLYTO(0.00)[cem@freebsd.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; RWL_MAILSPIKE_GOOD(0.00)[209.85.210.54:from]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-0.07)[-0.066]; FREEMAIL_TO(0.00)[gmail.com]; FORGED_SENDER(0.30)[cem@freebsd.org,csecem@gmail.com]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; FROM_NEQ_ENVFROM(0.00)[cem@freebsd.org,csecem@gmail.com]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.63)[-0.630]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; NEURAL_HAM_LONG(-0.97)[-0.969]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.210.54:from]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jun 2020 00:44:12 -0000 On Wed, Jun 17, 2020 at 4:04 AM Konstantin Belousov w= rote: > > On Tue, Jun 16, 2020 at 10:53:56PM +0000, Conrad Meyer wrote: > > Author: cem > > Date: Tue Jun 16 22:53:56 2020 > > New Revision: 362253 > > URL: https://svnweb.freebsd.org/changeset/base/362253 > > > > Log: > > vm: Drop vm_map_clip_{start,end} macro wrappers > > > > No functional change. > > > > Reviewed by: dougm, markj > > Sponsored by: Dell EMC Isilon > > Differential Revision: https://reviews.freebsd.org/D25282 > > I would highly appreciate if you revert this commit. > It conflicts with https://reviews.freebsd.org/D24652, which must revert y= our > change to remain functional. > I probably should not allowed that review to rott silently. Initially, I took a similar approach =E2=80=94 converting the macros to inl= ine functions. It was suggested in the review to just merge them, as they were both relatively small. I have a follow-up patch which will add a small amount of code to the former macros. (D25283) I don't think there is any functional reason your patch cannot be rebased over this change. You could choose to merge _vm_map_clip_start and vm_map_clip_start (and same for end) in your patch; nothing invokes the underscore variants except the wrappers. You could also choose to re-split the routines, although I'm not sure why. Either option seems acceptable to me. Best, Conrad