From owner-freebsd-hackers@freebsd.org Wed Feb 14 07:56:41 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 51E59F09630 for ; Wed, 14 Feb 2018 07:56:41 +0000 (UTC) (envelope-from 6yearold@gmail.com) Received: from mail-pl0-x22a.google.com (mail-pl0-x22a.google.com [IPv6:2607:f8b0:400e:c01::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C46A7695BE for ; Wed, 14 Feb 2018 07:56:40 +0000 (UTC) (envelope-from 6yearold@gmail.com) Received: by mail-pl0-x22a.google.com with SMTP id 31so2603931ple.9 for ; Tue, 13 Feb 2018 23:56:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=f0X+piOfwIvja6v/aqTlx93j1Bl3K6CedgqGTZrfdzY=; b=Y9QkK98GXoBlfavyBocnU7AkIaZhVlXCSV/zDUGBpk//9/bqWsnnBU1pE3lKAqDVjC t0ZF8xcc+Yy2PVx8XdUJq0CI6g41ruCHpenWrEPwjFVyNvktC5KNRWcOweD6g9NQcU+r AyYAouLtML0jfMcHUt7q2/HglvCE0gj0l0XrZ62Bv7V6qWF90RTgKEF65rRp6z/8JtB2 u5e2HmXmgwVRfoxrTKWNSWKpAGOWqTLwcEfRw2A1/baifbgNgFsHFHwjCtMiWL425jEn B3UiqinwQDjaSZjljTEYoswGm7iF0aza2+dzb7J+TfVDvZCMOvYkU5iqo5ycGIBfXKIS zOCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=f0X+piOfwIvja6v/aqTlx93j1Bl3K6CedgqGTZrfdzY=; b=NlqZbjyzSeWOOvOhS0HsT/k2A0ZI9M4GEKx6Zg4WCgXdGbLU25TyRQgKvMkTha154o 8Mggl9cZ2Z+uokCqyBfk2kkc1leVGilxPG0u0AdGvzYRb0zf4skzSmN6wKbE+j1526ky Q0VlaU52Ha1uFkFI9zzpkoXTOpEap29JSHcuA5LlLEZUC5Nc/mHUpXpMDzi0uyI1AM58 IXXTH/gE6efW3k8g5DiuAIHqkZuNe8iTyWSHqlUorMo/Ei/V1I1GjWlKE2hJUaXpemhc NiuwFmNzre/ZOmp5cOAHF/4+FexIOR+TdzbJ3pkXJR9Oz110aaRKbOqvFHPMP52S4vir aDIw== X-Gm-Message-State: APf1xPAL+D4HEoqpg11eIhEIo7tjzEeD7lCGQVBpyS/e5vPmSJaOVnZx tsa1q8N+sh9vMLJGVxa1EKGtohaZ0oqnBfFPIVzrdg== X-Google-Smtp-Source: AH8x225DO6R7WEBNZH23/95I6YeWu0Hm2HiftHXROU1i0gAHyrpbBLFjKfJXaZuMBAeKWFnDTwtlReQq/vVSiHGlCsw= X-Received: by 2002:a17:902:36a:: with SMTP id 97-v6mr3724893pld.365.1518594999646; Tue, 13 Feb 2018 23:56:39 -0800 (PST) MIME-Version: 1.0 Received: by 10.100.155.47 with HTTP; Tue, 13 Feb 2018 23:56:09 -0800 (PST) In-Reply-To: References: From: Gleb Popov <6yearold@gmail.com> Date: Wed, 14 Feb 2018 10:56:09 +0300 Message-ID: Subject: Re: select call in devd To: Eitan Adler Cc: FreeBSD Hackers Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Feb 2018 07:56:41 -0000 On Wed, Feb 14, 2018 at 10:13 AM, Eitan Adler wrote: > Hi all, > > select(2) is declared with restrict for the pointers for fd. Can y'all > confirm this is the correct fix? > > It is only lightly tested (it seems to do its job on my machine) > > Index: devd.cc > =================================================================== > --- devd.cc (revision 329192) > +++ devd.cc (working copy) > @@ -1021,7 +1021,7 @@ event_loop(void) > tv.tv_usec = 0; > FD_ZERO(&fds); > FD_SET(fd, &fds); > - rv = select(fd + 1, &fds, &fds, &fds, &tv); > + rv = select(fd + 1, &fds, NULL, NULL, &tv); > // No events -> we've processed all pending events > if (rv == 0) { > devdlog(LOG_DEBUG, "Calling daemon\n"); > > > -- > Eitan Adler > _______________________________________________ > freebsd-hackers@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org" > Haven't looked at code at all, but why is it using select and not kqueue/kevent?