From owner-freebsd-current@FreeBSD.ORG  Tue Dec 27 10:42:03 2011
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3B82E106564A;
	Tue, 27 Dec 2011 10:42:03 +0000 (UTC) (envelope-from philip@paeps.cx)
Received: from rincewind.paeps.cx (rincewind.paeps.cx
	[IPv6:2002:596a:f092::149])
	by mx1.freebsd.org (Postfix) with ESMTP id F00338FC20;
	Tue, 27 Dec 2011 10:42:02 +0000 (UTC)
Received: from twoflower.paeps.cx (unknown [176.99.70.219])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client CN "twoflower.paeps.cx",
	Issuer "CAcert Class 3 Root" (verified OK))
	by rincewind.paeps.cx (Postfix) with ESMTPS id 0CE3BD74495;
	Tue, 27 Dec 2011 11:41:53 +0100 (CET)
Received: by twoflower.paeps.cx (Postfix, from userid 1001)
	id F13EB3E2106; Tue, 27 Dec 2011 02:04:49 +0100 (CET)
Date: Tue, 27 Dec 2011 02:04:49 +0100
From: Philip Paeps <philip@freebsd.org>
To: freebsd-current@freebsd.org, current@freebsd.org, freebsd-arch@freebsd.org
Message-ID: <20111227010449.GA6244@twoflower.paeps.cx>
Mail-Followup-To: freebsd-current@freebsd.org, current@freebsd.org,
	freebsd-arch@freebsd.org
References: <20111226101040.GA6361@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20111226101040.GA6361@freebsd.org>
X-PGP-Fingerprint: 356B AE02 4763 F739 2FA2  E438 2649 E628 C5D3 4D05
X-Date: Today is Sweetmorn, the 69th day of The Aftermath in the YOLD 3177
X-Phase-of-Moon: The Moon is Waxing Crescent (7% of Full)
X-Philip-Conspiracy: There is no conspiracy
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: 
Subject: Re: [rfc] removing/conditionalising WERROR= in Makefiles
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Dec 2011 10:42:03 -0000

On 2011-12-26 10:10:40 (+0000), Alexander Best <arundel@freebsd.org> wrote:
> i grep'ed through src/sys and found several places where WERROR= was set in
> order to get rid of the default -Werror setting. i tried to remove those
> WERROR= overrides from any Makefile, where doing so did not break tinderbox.
> 
> in those cases, where it couldn't be completely removed, i added conditions to
> only set WERROR= for the particular achitecture or compiler, where tinderbox
> did not suceed without the WERROR=.

Wouldn't it be better to set WARNS=x rather than WERROR=?  WERROR= says "this
code has bugs, it breaks tinderbox" whereas WARNS=x says "this code has the
following kind of bugs which break tinderbox".

Possibly wrapped in an architecture-test where appropriate.

 - Philip

-- 
Philip Paeps
Senior Reality Engineer
Ministry of Information