From owner-svn-src-all@FreeBSD.ORG Fri Mar 12 17:30:45 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9F78F106564A; Fri, 12 Mar 2010 17:30:45 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 583858FC1C; Fri, 12 Mar 2010 17:30:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o2CHLerq069594; Fri, 12 Mar 2010 10:21:40 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Fri, 12 Mar 2010 10:21:47 -0700 (MST) Message-Id: <20100312.102147.1139860627944844739.imp@bsdimp.com> To: jmallett@freebsd.org From: "M. Warner Losh" In-Reply-To: References: <9ace436c1003111530s3bd0de9cq451671909fb6aa64@mail.gmail.com> X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, qingli@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, rwatson@freebsd.org Subject: Re: svn commit: r205024 - head/sys/net X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Mar 2010 17:30:45 -0000 In message: Juli Mallett writes: : On Thu, Mar 11, 2010 at 15:30, Qing Li wrote: : >> : >> A couple of questions: : >> : >> (1) It used to be the case that quite a few interface drivers and = types : >> didn't have a notion of "link up" -- especially older ethernet dev= ices. =A0Do : >> those all have the same problem? =A0It was probably a design overs= ight that : >>=A0devices don't declare an explicit capability for "can report lin= k state". : >> : > : > =A0What you raised is definitely a possibility and these fixes take= the : > =A0similar approach. I am going to try and go through each of these= : > =A0drivers in /sys/dev/ and converting them, very soon. : = : Go through drivers in the embedded port directories, too. The Octeon= : port's Ethernet driver was broken by this, and it looks like the : Atheros if_arge is probably broken, too. I would even suggest going : back to the old behavior briefly while the port maintainers are given= : an opportunity to update their drivers. Actually, it looks like only= : MIPS has Ethernet drivers outside of dev/ at a quick glance, but I'd : be surprised if there weren't other broken examples. arm has them as well. sys/arm/at91/if_ate.c. Powerpc does as well. Warner