From owner-freebsd-hackers@FreeBSD.ORG  Tue Nov 13 12:06:45 2012
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 9A55E8CD;
 Tue, 13 Nov 2012 12:06:45 +0000 (UTC) (envelope-from uqs@FreeBSD.org)
Received: from acme.spoerlein.net (acme.spoerlein.net
 [IPv6:2a01:4f8:131:23c2::1])
 by mx1.freebsd.org (Postfix) with ESMTP id 213C98FC19;
 Tue, 13 Nov 2012 12:06:44 +0000 (UTC)
Received: from localhost (acme.spoerlein.net [IPv6:2a01:4f8:131:23c2::1])
 by acme.spoerlein.net (8.14.5/8.14.5) with ESMTP id qADC6hp5027808
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);
 Tue, 13 Nov 2012 13:06:43 +0100 (CET) (envelope-from uqs@FreeBSD.org)
Date: Tue, 13 Nov 2012 13:06:43 +0100
From: Ulrich =?utf-8?B?U3DDtnJsZWlu?= <uqs@FreeBSD.org>
To: hiren panchasara <hiren.panchasara@gmail.com>
Subject: Re: Porting patch(1) from NetBSD to FreeBSD (was Re: FreeBSD in
 Google Code-In 2012? You can help too!)
Message-ID: <20121113120642.GW69724@acme.spoerlein.net>
Mail-Followup-To: hiren panchasara <hiren.panchasara@gmail.com>,
 Garrett Cooper <yanegomi@gmail.com>,
 Gabor Kovesdan <gabor@kovesdan.org>, freebsd-hackers@freebsd.org,
 Adrian Chadd <adrian@freebsd.org>, Pedro Giffuni <pfg@freebsd.org>
References: <CALCpEUHXkyPgqaypkiatx978jjMbiYtvMZC3nNHNpnRSdLf=PA@mail.gmail.com>
 <508D0F11.1060203@kovesdan.org>
 <CAJ-VmomQVC-OfY7a+-tH0W9ekHGW6JidQ869Q6H94pTSk8xoKQ@mail.gmail.com>
 <CAGH67wT-GO2a2n3RcXd0_TE+WDhJSwjvOst9vFrZJG5SNz0kFA@mail.gmail.com>
 <CALCpEUExcpDUb9uDieB-WEkdkc6SPr+XX-zvC-qScw-uiBwSiw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CALCpEUExcpDUb9uDieB-WEkdkc6SPr+XX-zvC-qScw-uiBwSiw@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: Garrett Cooper <yanegomi@gmail.com>, Gabor Kovesdan <gabor@kovesdan.org>,
 Adrian Chadd <adrian@FreeBSD.org>, Pedro Giffuni <pfg@FreeBSD.org>,
 freebsd-hackers@FreeBSD.org
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
 <freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
 <mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Nov 2012 12:06:45 -0000

On Mon, 2012-10-29 at 23:13:00 -0700, hiren panchasara wrote:
> Thank you all for the inputs.
> I understand this is a long grueling process so I will attempt to do things
> in approximately following order:
> 
> 1) prepare a new port for bsd patch
> 2) make sure new bsd patch has all options of existing gnu patch
> 3) merge outstanding patches:
> http://svnweb.freebsd.org/base/head/gnu/usr.bin/patch/?view=log
> 4) bug compatibility
> 5) performance

For 2) and 4) (maybe also 5?) you really should look into ATF and come
up with some test cases for each option, someone else also mentioned
unit tests that GNU patch ships with?

We really would like to see *BSD patch in the base, but it should come
with unit tests; it is 2012, after all :)

Thanks!
Uli