From owner-freebsd-acpi@FreeBSD.ORG Tue Sep 11 21:49:22 2007 Return-Path: Delivered-To: acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9865716A421 for ; Tue, 11 Sep 2007 21:49:22 +0000 (UTC) (envelope-from william88@gmail.com) Received: from rv-out-0910.google.com (rv-out-0910.google.com [209.85.198.190]) by mx1.freebsd.org (Postfix) with ESMTP id 6B30A13C47E for ; Tue, 11 Sep 2007 21:49:22 +0000 (UTC) (envelope-from william88@gmail.com) Received: by rv-out-0910.google.com with SMTP id l15so1433rvb for ; Tue, 11 Sep 2007 14:49:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references; bh=mI6Q26WxmzN9GYHbYTI6HUXKgnbud09uR/N16yq6Fnw=; b=A3GI4si7iCuzcuiw2XmnLvsLQi9zMWGLuuYoGM48U8Z61kgknS/kN0gNPJOPSbgL1g4keQJabxtaU1C/Wboew2PQV3fJfHOlzGV8ZXncMyMKmxn2PruhUSYFuCK1U8BmmqynqwqSJIDClos8ybXWto6z093mgs9lTLr4/ZgSW/4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references; b=dnU6eicpXGtC9TsrAN2y2drGOEeGvd2poLQr4VoYBXZsVpwLIbv5dx3QP59KSL7KOlGTmoNQiK6rWeplQaBTIK9MCmPKuVFMePjzrJKAcqhCGQORcRCRcEcWjEvw2PbNnF2nbfeNBR+QKWLSkM+UwLXZS7SkmVDLhtTyGOYp9fg= Received: by 10.140.133.10 with SMTP id g10mr2600351rvd.1189547361745; Tue, 11 Sep 2007 14:49:21 -0700 (PDT) Received: by 10.141.136.13 with HTTP; Tue, 11 Sep 2007 14:49:21 -0700 (PDT) Message-ID: <632825b40709111449uf8e184cv2623b052d6013b82@mail.gmail.com> Date: Tue, 11 Sep 2007 18:49:21 -0300 From: "William Grzybowski" To: "Nate Lawson" In-Reply-To: <46E6DF34.1060304@root.org> MIME-Version: 1.0 References: <46E0777A.8070901@root.org> <46E07AAF.2060000@root.org> <632825b40709070752o6fe867a2s3e7647e5444b1b5b@mail.gmail.com> <46E6DF34.1060304@root.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: acpi@freebsd.org, current@freebsd.org Subject: Re: PATCH: ecng for 6.x and 7.x X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Sep 2007 21:49:22 -0000 On 9/11/07, Nate Lawson wrote: > > William Grzybowski wrote: > > On 9/6/07, *Nate Lawson* > wrote: > > > > Nate Lawson wrote: > > > I've done some major rework on the EC driver. This should help > with > > > various problems, including timeouts while checking battery status > or > > > temperature. The attached patches are for 6.x and 7.x. Please > > test and > > > let me know if you get any new errors on dmesg or if it fixes > > things for > > > you (especially HP/Compaq laptop owners). > > > > > > If you still have problems, try setting each of these tunables > > > individually and then both together (i.e., in > > /boot/loader.conf). Note > > > that this will be four (4) test runs total, so don't just set both > and > > > say it doesn't work. > > > > > > debug.acpi.ec.burst= "1" > > > debug.acpi.ec.polled="1" > > > > > > I've tested both patches on a Panasonic Y4 and UnnamedOEM laptop, > no > > > problems in either regular or burst mode. > > > > > > > > > Commit message: > > > Rewrite the EC driver event model. The main goal is to avoid > > > polling/interrupt-driven fallback and instead use polling only > during > > > boot and pure interrupt-driven mode after boot. Polled mode could > be > > > relegated completely to a legacy role if we could enable > interrupts > > > during boot. Polled mode can be forced after boot by setting > > > debug.acpi.ec.polled="1", i.e. if there are timeouts. > > > > One minor note -- power off shutdown (shutdown/halt -p) is turned > into a > > (safe) reboot with this patch. I have tested the fix, which is just > to > > force polled mode during shutdown as well. I don't have time to > > re-roll > > the patch today but will send tomorrow. > > > > Please test the patch as posted, ignoring that minor issue. The > test > > results during normal use are still valid. > > > > > > Hi Nate, > > > > I tested this patch on my acer notebook (intel chipset) and i did not > > notice any changes, unless some errors on dmesg, like: > > acpi_ec0: EcCommand: no response to 0x84 > > acpi_ec0: GPE query failed: AE_NO_HARDWARE_RESPONSE > > acpi_ec0: EcCommand: no response to 0x82 > > acpi_ec0: EcCommand: no response to 0x80 > > ACPI Error (psparse-0626): Method parse/execution failed > > [\\_TZ_.THRM._TMP] (Node 0xc3bbdcc0), AE_NO_HARDWARE_RESPONSE > > ACPI Error (psparse-0626): Method parse/execution failed > > [\\_SB_.ACAD._PSR] (Node 0xc3bc02a0), AE_NO_HARDWARE_RESPONSE > > As I noted before, your system enters the poll loop with the status > appearing to be already complete. Can you get back to me on my previous > questions, especially whether forcing polled mode works for you? I > didn't see any errors in that dmesg case. > > I've updated the patches to do one final check if the interrupt-driven > mode gets a timeout. If the status is complete, it will force the > system back into polled mode since interrupt mode doesn't work. It also > has a case for polled mode during boot where the status appears to be > already complete. It waits a short while before actually checking the > status, just in case the EC is really slow and hasn't gotten to work on > the new request yet. > > Give it a try also, with no tunables set. > Hi, Unfortunelly I don't had time to complete the tests which you asked to, i got a lot of work ;(. Tomorrow I will use my free time to do it all and the new ones. Thanks Nate. -- William Grzybowski ------------------------------------------ Jabber: william88 at gmail dot com Curitiba/PR - Brazil