From owner-svn-src-head@freebsd.org  Fri Aug 26 19:57:45 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id D3C6AB76A49;
 Fri, 26 Aug 2016 19:57:45 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id B1D34DEA;
 Fri, 26 Aug 2016 19:57:45 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net
 [73.231.226.104])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id 2D3E6B96C;
 Fri, 26 Aug 2016 15:57:44 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Ed Schouten <ed@nuxi.nl>
Cc: Bryan Drewery <bdrewery@freebsd.org>, Guido Falsi <madpilot@freebsd.org>,
 svn-src-head@freebsd.org, jilles@freebsd.org, svn-src-all@freebsd.org,
 src-committers <src-committers@freebsd.org>, Ed Schouten <ed@freebsd.org>
Subject: Re: svn commit: r303988 - head/lib/libc/gen
Date: Fri, 26 Aug 2016 12:57:41 -0700
Message-ID: <2038784.5k3koFGWFB@ralph.baldwin.cx>
User-Agent: KMail/4.14.3 (FreeBSD/10.3-STABLE; KDE/4.14.3; amd64; ; )
In-Reply-To: <CABh_MKnHa-djy_HVEGhCM8xAjOXwrhdP7Sh-Gr6v09nrbS5pnw@mail.gmail.com>
References: <201608120703.u7C73whf007189@repo.freebsd.org>
 <1ce79adf-94cc-e5d3-7b8b-0914f2b07512@FreeBSD.org>
 <CABh_MKnHa-djy_HVEGhCM8xAjOXwrhdP7Sh-Gr6v09nrbS5pnw@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Fri, 26 Aug 2016 15:57:44 -0400 (EDT)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 26 Aug 2016 19:57:45 -0000

On Friday, August 26, 2016 09:37:10 AM Ed Schouten wrote:
> Hi,
> 
> 2016-08-26 1:52 GMT+02:00 Bryan Drewery <bdrewery@freebsd.org>:
> > Libc wouldn't build, it complained quite loudly with a lot of these:
> 
> Got it. Thinking ahead, if it's just basename() giving the problems,
> maybe it's easier to just go ahead and bump the symver of basename()
> as well? I'm planning on replacing it anyway to be in sync with the
> new basename() anyway. Attached is a new patch. Be sure to let me know
> whether that works for you.

Alternatively, couldn't you just leave basename out of the libgen patch
for now and only add it once you do the real symver bump for the
different version?  (That is, just use __generic() for dirname() for
now since that is the only one that has really changed.)

-- 
John Baldwin