From owner-dev-commits-src-all@freebsd.org Thu Sep 9 14:33:56 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3BBA567125A; Thu, 9 Sep 2021 14:33:56 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4H51j0118Fz4f94; Thu, 9 Sep 2021 14:33:56 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id EFC5826868; Thu, 9 Sep 2021 14:33:55 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qv1-f46.google.com with SMTP id 93so1247897qva.7; Thu, 09 Sep 2021 07:33:55 -0700 (PDT) X-Gm-Message-State: AOAM530Zvm8A82wr/UJ0T92gD7KAx7+wzMA80Jeu7NeJJNG9IA2YKiuw PPGZwjvtxGCoS+VV1kyHmUrF/WM4LkSMNNaIc4U= X-Google-Smtp-Source: ABdhPJzDHQICl5LtBCFYsnt9EykL4liC0hBnrLzywE3rniFRHpiU5TwPntRvTTK0BhYzw7AAIpl2MGbrCb2NE5IR+yE= X-Received: by 2002:a05:6214:f68:: with SMTP id iy8mr3061822qvb.51.1631198035441; Thu, 09 Sep 2021 07:33:55 -0700 (PDT) MIME-Version: 1.0 References: <202109080107.18817pdj030849@gitrepo.freebsd.org> <8309c83d-9dc2-d0bc-3985-b5d7a5c853f1@FreeBSD.org> In-Reply-To: <8309c83d-9dc2-d0bc-3985-b5d7a5c853f1@FreeBSD.org> From: Kyle Evans Date: Thu, 9 Sep 2021 09:33:44 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 19261079b743 - main - openssh: update to OpenSSH v8.7p1 To: Guido Falsi Cc: Ed Maste , src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Sep 2021 14:33:56 -0000 On Thu, Sep 9, 2021 at 6:24 AM Guido Falsi wrote: > > On 08/09/21 03:07, Ed Maste wrote: > > The branch main has been updated by emaste: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=19261079b74319502c6ffa1249920079f0f69a72 > > > > commit 19261079b74319502c6ffa1249920079f0f69a72 > > Merge: c5128c48df3c 66719ee573ac > > Author: Ed Maste > > AuthorDate: 2021-09-08 01:05:51 +0000 > > Commit: Ed Maste > > CommitDate: 2021-09-08 01:05:51 +0000 > > > > openssh: update to OpenSSH v8.7p1 > > > > Some notable changes, from upstream's release notes: > > > > - sshd(8): Remove support for obsolete "host/port" syntax. > > - ssh(1): When prompting whether to record a new host key, accept the key > > fingerprint as a synonym for "yes". > > - ssh-keygen(1): when acting as a CA and signing certificates with an RSA > > key, default to using the rsa-sha2-512 signature algorithm. > > - ssh(1), sshd(8), ssh-keygen(1): this release removes the "ssh-rsa" > > (RSA/SHA1) algorithm from those accepted for certificate signatures. > > - ssh-sk-helper(8): this is a new binary. It is used by the FIDO/U2F > > support to provide address-space isolation for token middleware > > libraries (including the internal one). > > - ssh(1): this release enables UpdateHostkeys by default subject to some > > conservative preconditions. > > - scp(1): this release changes the behaviour of remote to remote copies > > (e.g. "scp host-a:/path host-b:") to transfer through the local host > > by default. > > - scp(1): experimental support for transfers using the SFTP protocol as > > a replacement for the venerable SCP/RCP protocol that it has > > traditionally used. > > > > Additional integration work is needed to support FIDO/U2F in the base > > system. > > > > Deprecation Notice > > ------------------ > > > > OpenSSH will disable the ssh-rsa signature scheme by default in the > > next release. > > > > Reviewed by: imp > > MFC after: 1 month > > Relnotes: Yes > > Sponsored by: The FreeBSD Foundation > > Differential Revision: https://reviews.freebsd.org/D29985 > > > > While upgrading my current machines I encountered an issue with pam_ssh > which seems to be caused by this update. > > I filed a bug report with all the details: > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=258384 > > Could you take a look? > > Seems to be caused by the ssh code trying to call a function available > only when FIDO/U2F support is enabled, which is not the case in our > source base. > > I tried a quick fix by adding some ifdefs, but it failed to make it > work, I'm still trying to find a solution myself. > Looks like the reference in openssh/sshkey.c... probably the correct thing to do is add ssh-sk.c to the secure/lib/libssh build; it still requires additional integration for FIDO/U2F, though.