Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 18 Jul 2020 12:22:28 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 248063] www/gitea: Installation from source fails when using portmaster (variable PACKAGES preassigned by the port system)
Message-ID:  <bug-248063-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D248063

            Bug ID: 248063
           Summary: www/gitea: Installation from source fails when using
                    portmaster (variable PACKAGES preassigned by the port
                    system)
           Product: Ports & Packages
           Version: Latest
          Hardware: amd64
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: ports-bugs@FreeBSD.org
          Reporter: johannes.kunde@gmail.com
                CC: stb@lassitu.de
             Flags: maintainer-feedback?(stb@lassitu.de)
                CC: stb@lassitu.de

When using portmaster to build gitea from source (latest version 1.11.8), t=
he
build operation fails with the following output:

gmake[1]: Entering directory '/usr/ports/www/gitea/work/gitea-1.11.8'
GO111MODULE=3Don go generate -mod=3Dvendor /usr/ports/packages
can't load package: package /usr/ports/packages: cannot find package
gmake[1]: *** [Makefile:433: generate] Error 1
gmake[1]: Leaving directory '/usr/ports/www/gitea/work/gitea-1.11.8'
*** Error code 1

Stop.
make: stopped in /usr/ports/www/gitea


The problem is that gitea uses a variable with the name 'PACKAGES' in it's
Makefile. This variable is already used bei the port system itself and poin=
ts
at '/usr/ports/packages' (see also error message above):

root@test:/usr/ports/www/gitea # make -V PACKAGES
/usr/ports/packages

In line 54 of gitea's Makefile the variable PACKAGES get's assigned only if=
 it
is not already set (note the question mark: PACKAGES ?=3D ...) - but it is
already set.

The error can be solved by simply removing the "?" in line 54 and hardly as=
sign
PACKAGES with the proposed value:

root@test:/usr/ports/www/gitea/work/gitea-1.11.8 # diff Makefile Makefile.b=
ak=20
54c54
< PACKAGES =3D $(filter-out
code.gitea.io/gitea/integrations/migration-test,$(filter-out
code.gitea.io/gitea/integrations,$(shell GO111MODULE=3Don $(GO) list -mod=
=3Dvendor
./... | grep -v /vendor/)))
---
> PACKAGES ?=3D $(filter-out code.gitea.io/gitea/integrations/migration-tes=
t,$(filter-out code.gitea.io/gitea/integrations,$(shell GO111MODULE=3Don $(=
GO) list -mod=3Dvendor ./... | grep -v /vendor/)))


Naming the variable GO_PACKAGES instead however would be more accurate, but
would also result in more changes.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-248063-7788>