From owner-svn-src-head@FreeBSD.ORG Mon Sep 8 02:18:22 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 939717BE; Mon, 8 Sep 2014 02:18:22 +0000 (UTC) Received: from pp1.rice.edu (proofpoint1.mail.rice.edu [128.42.201.100]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 545221ACE; Mon, 8 Sep 2014 02:18:21 +0000 (UTC) Received: from pps.filterd (pp1.rice.edu [127.0.0.1]) by pp1.rice.edu (8.14.5/8.14.5) with SMTP id s882HL0q001698; Sun, 7 Sep 2014 21:18:14 -0500 Received: from mh11.mail.rice.edu (mh11.mail.rice.edu [128.42.199.30]) by pp1.rice.edu with ESMTP id 1p8w07g3ht-1; Sun, 07 Sep 2014 21:18:14 -0500 X-Virus-Scanned: by amavis-2.7.0 at mh11.mail.rice.edu, auth channel Received: from 108-254-203-201.lightspeed.hstntx.sbcglobal.net (108-254-203-201.lightspeed.hstntx.sbcglobal.net [108.254.203.201]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) (Authenticated sender: alc) by mh11.mail.rice.edu (Postfix) with ESMTPSA id ADA004C00A5; Sun, 7 Sep 2014 21:18:13 -0500 (CDT) Message-ID: <540D11E2.9020804@rice.edu> Date: Sun, 07 Sep 2014 21:18:10 -0500 From: Alan Cox User-Agent: Mozilla/5.0 (X11; FreeBSD i386; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Peter Wemm , Alan Cox Subject: Re: svn commit: r271243 - head/sys/vm References: <201409080019.s880J4c8002174@svn.freebsd.org> <5093630.OkGduFpJtx@overcee.wemm.org> In-Reply-To: <5093630.OkGduFpJtx@overcee.wemm.org> X-Enigmail-Version: 1.6 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 kscore.is_bulkscore=1.99840144432528e-15 kscore.compositescore=9.42127164060835e-08 circleOfTrustscore=0 compositescore=0.601496849000349 urlsuspect_oldscore=0.00149684900034924 suspectscore=3 recipient_domain_to_sender_totalscore=0 phishscore=0 bulkscore=0 kscore.is_spamscore=0 recipient_to_sender_totalscore=0 recipient_domain_to_sender_domain_totalscore=0 rbsscore=0.601496849000349 spamscore=0 recipient_to_sender_domain_totalscore=0 urlsuspectscore=0.9 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1402240000 definitions=main-1409080026 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Sep 2014 02:18:22 -0000 On 09/07/2014 21:14, Peter Wemm wrote: > On Monday, September 08, 2014 12:19:04 AM Alan Cox wrote: > >> Log: >> Make two functions static and eliminate an unused #define. > > Unfortunately, the code (and compiler) disagrees.. > >> @@ -1504,7 +1507,7 @@ again: >> * possibly extended). When merging, this routine may delete one or >> * both neighbors. >> */ >> -void >> +static void >> vm_map_simplify_entry(vm_map_t map, vm_map_entry_t entry) >> { >> vm_map_entry_t next, prev; > > > sys/security/mac/mac_process.c:366:4: error: implicit declaration of function > 'vm_map_simplify_entry' is invalid in C99 [-Werror,-Wimplicit-function- > declaration] > vm_map_simplify_entry(map, vme); > > The code in question: > > static void > mac_proc_vm_revoke_recurse(struct thread *td, struct ucred *cred, > struct vm_map *map) > { > vm_map_entry_t vme; > ... > vm_map_simplify_entry(map, vme); > ^^^^^^^^^^^^^^^^^^^^^^ > } > } > vm_map_unlock(map); > } > > Ya, I just saw that, and was rather surprised.