From nobody Wed Nov 17 05:10:50 2021 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 2B3541857A33; Wed, 17 Nov 2021 05:10:51 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Hv9xR0pPpz4h54; Wed, 17 Nov 2021 05:10:51 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1637125851; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9NDVz/GSwJVCKsgzu/4NFhZdwDzYI1MlN30SqsVtW/Y=; b=LVe7PJL76qcbMONwqUaFFalOihpqZmbjIIhBfu2xVLhXgGdW0pVerNM9ZzXcTLUdP64/q/ xn4YKh7Ih7t0gJOz3Fd+29+azchDw3lJ6lCxWhrhKoEAr3nEmjGoLkMehv/uZnm5saivct KWWRR+F6z0x5wY5oWujHlA0K0BTb85F80tDj1jaKF7LMm9TkamFp93LojqbUDvKZ1J0Qm8 WDx3qb5cNbTRFRHhW4NyRRVaLmSiasUb3Dij3rTNm09N+EeLdtTLKsn7Lf3O6DPMRpTPvW bTfGZULBa/GUzxXMhAauzOVuGUxnvwn3WfSEFGWlUFxrm2BEFPJFHYFK6WPp1g== Received: by freefall.freebsd.org (Postfix, from userid 1033) id F04F44063; Wed, 17 Nov 2021 05:10:50 +0000 (UTC) Date: Wed, 17 Nov 2021 05:10:50 +0000 From: Alexey Dokuchaev To: Yasuhiro Kimura Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: bb8dbe1580ae - main - sysutils/lnav: Fix distinfo Message-ID: References: <20211117.124452.1254944101155682425.yasu@utahime.org> <20211117.132859.1875579380149864513.yasu@FreeBSD.org> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211117.132859.1875579380149864513.yasu@FreeBSD.org> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1637125851; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9NDVz/GSwJVCKsgzu/4NFhZdwDzYI1MlN30SqsVtW/Y=; b=BxrzAvNToWZUkOCfM9hfDVbkjA+v8WhktUY4kIgVmdCPsmicPVNlWECIsJihakSqTk56c/ pyjy5iF+YTukOnSZ2XdhTJLLMVnkhW6crx2W4jMStlZd4/7qL6ij4z1ZxKfLwzLK3RJaPw nJqfjHtA1Y0hU1htx0yjCK3LD/IUJVDwy58V1SsasnZlt0x4LojNAFBfkKVz8INCAr6R2O moxTu6NTi6V0B6pv2zvmBWhqUApmldtaNompDLKbXJ4q83NCe+MrG3djhSw/kdFT52CjL8 I9esg53nhnZr1EQmtkYeb4XEwbzJe6sxqDS79fh7mFduRP/xUZeaVb9hOk+U8A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1637125851; a=rsa-sha256; cv=none; b=Bdol6uv2eVVIR0wtI4TY15v9BaM/hD9UIyQ+uHkIHExIIFipjuzhUfwlLaiGKzmYJQFzGO 2UK4f3Rv89+NOnKvU84EPF1HfrVK05BHQMxIFVyl5YlFeWs4OPz+yf7YPmxw6D24PSArcv 5kxTjqED/lksOgws1UEJpT2UMqxGtjbmLWxhqktZB594ny/kMT5UN7Qyh4GuAVY5Y3Stha f1pE6tBusoLDl270eqB/AsjDoN0GZXthGz7srhAr9EBz2HnRQ4riDaBUe4zb9bDAgB6FVr gbyZXKKSJAo5r+/jPMCWynoO6VruHJn/coi0dVJA8THmuT7DIKEmqS/2XiRT/A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Wed, Nov 17, 2021 at 01:28:59PM +0900, Yasuhiro Kimura wrote: > ... > have no preference about it. I just keep what is written. So I'm just > confused to be complained about it to me. Kimura-san, I guess I shouldn't have concentrate on this DIST/PORT version thing which drove attention away from the main point, which is why gratuitous changes are pessimization and should be avoided (we'd also ignore the SNR issue for now). Previously, the Makefile reader would see the commit which updated the port to version 0.10.1 in the plain "git blame Makefile" output. Now, it's clobbered, so takes a "git blame bb8dbe1580ae0^ Makefile" to get the needed hash. Admittedly, you've done a good job providing enough details in the commit log, including the original update hash, but that does not happen all the time (most people are lazy), and does not relieve one of having to deal with incomprehensible git hashes (unlike small integer revisions we had before which could at least be recognized, if not memorized -- that helped with multi-level blaming a lot; now with git this is harder). ./danfe