From owner-svn-src-all@freebsd.org  Wed Jun  1 20:45:22 2016
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id E30E5B618C2;
 Wed,  1 Jun 2016 20:45:22 +0000 (UTC) (envelope-from ed@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id B077E1F0D;
 Wed,  1 Jun 2016 20:45:22 +0000 (UTC) (envelope-from ed@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u51KjLJV026870;
 Wed, 1 Jun 2016 20:45:21 GMT (envelope-from ed@FreeBSD.org)
Received: (from ed@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id u51KjLuF026869;
 Wed, 1 Jun 2016 20:45:21 GMT (envelope-from ed@FreeBSD.org)
Message-Id: <201606012045.u51KjLuF026869@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: ed set sender to ed@FreeBSD.org
 using -f
From: Ed Schouten <ed@FreeBSD.org>
Date: Wed, 1 Jun 2016 20:45:21 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r301167 - head/lib/libcasper/services/cap_grp
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Jun 2016 20:45:23 -0000

Author: ed
Date: Wed Jun  1 20:45:21 2016
New Revision: 301167
URL: https://svnweb.freebsd.org/changeset/base/301167

Log:
  Don't call setgrent() in an unportable way.
  
  For FreeBSD 12, I'm considering updating setgrent() to have a function
  prototype that conforms to POSIX. FreeBSD seems to be the only operating
  system that lets setgrent() return an integer. It's also inconsistent
  with setpwent().
  
  It looks like our libcasper depends on setgrent() returning an integer.
  Get rid of that.
  
  Reviewed by:	oshogbo
  Differential Revision:	https://reviews.freebsd.org/D6659

Modified:
  head/lib/libcasper/services/cap_grp/cap_grp.c

Modified: head/lib/libcasper/services/cap_grp/cap_grp.c
==============================================================================
--- head/lib/libcasper/services/cap_grp/cap_grp.c	Wed Jun  1 20:44:28 2016	(r301166)
+++ head/lib/libcasper/services/cap_grp/cap_grp.c	Wed Jun  1 20:45:21 2016	(r301167)
@@ -703,7 +703,9 @@ grp_setgrent(const nvlist_t *limits __un
     nvlist_t *nvlout __unused)
 {
 
-	return (setgrent() == 0 ? EFAULT : 0);
+	setgrent();
+
+	return (0);
 }
 
 static int