Skip site navigation (1)Skip section navigation (2)
Date:      Fri,  7 Mar 2008 09:55:18 +1100 (EST)
From:      Edwin Groothuis <edwin@mavetju.org>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   ports/121453: [patch] improve Mk/bsd.sites.mk MASTER_SITE_GOOGLE_CODE variable
Message-ID:  <20080306225518.1017A14D@k7.mavetju>
Resent-Message-ID: <200803062300.m26N02T8036613@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         121453
>Category:       ports
>Synopsis:       [patch] improve Mk/bsd.sites.mk MASTER_SITE_GOOGLE_CODE variable
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Mar 06 23:00:01 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Edwin Groothuis
>Release:        FreeBSD 6.3-RELEASE i386
>Organization:
>Environment:
System: FreeBSD k7.mavetju 6.3-RELEASE FreeBSD 6.3-RELEASE #0: Sun Feb 17 22:11:52 EST 2008 edwin@k7.mavetju:/usr/src/sys/i386/compile/SMP i386

>Description:

There are 18 ports which can't use the MASTER_SITE_GOOGLE_CODE
variable for MASTER_SITES yet because their PORTNAME insted the
same as the hostname. For example:

graphics/tesseract/Makefile:MASTER_SITES=       http://tesseract-ocr.googlecode.com/files/ CENKES
net-im/jabber-pyaim/Makefile:MASTER_SITES=      http://pyaimt.googlecode.com/files/
net-im/jabber-pyicq/Makefile:MASTER_SITES=      http://pyicqt.googlecode.com/files/

This patch introduces the GOOGLENAME variable which can be used to
overcome this problem.


>How-To-Repeat:
>Fix:

I submitted this as a PR instead of just commited it because it
might cause some controvacy.

Index: Mk/bsd.sites.mk
===================================================================
RCS file: /home/pcvs/ports/Mk/bsd.sites.mk,v
retrieving revision 1.439
diff -u -r1.439 bsd.sites.mk
--- Mk/bsd.sites.mk     6 Mar 2008 21:32:03 -0000       1.439
+++ Mk/bsd.sites.mk     6 Mar 2008 22:50:41 -0000
@@ -596,9 +596,14 @@
 .endif
 
 .if !defined(IGNORE_MASTER_SITE_GOOGLE_CODE)
+.if defined(GOOGLENAME)
+MASTER_SITE_GOOGLE_CODE+= \
+       http://${GOOGLENAME}.googlecode.com/files/
+.else
 MASTER_SITE_GOOGLE_CODE+= \
        http://${PORTNAME}.googlecode.com/files/
 .endif
+.endif
 
 .if !defined(IGNORE_MASTER_SITE_HORDE)
 MASTER_SITE_HORDE+=    \

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080306225518.1017A14D>