From nobody Sun Jul 13 14:53:42 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bg7kS0CPLz614Z7; Sun, 13 Jul 2025 14:53:52 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bg7kR2CHXz3Vfb; Sun, 13 Jul 2025 14:53:51 +0000 (UTC) (envelope-from markjdb@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-qk1-x735.google.com with SMTP id af79cd13be357-7dd8773f9d9so279611585a.2; Sun, 13 Jul 2025 07:53:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752418425; x=1753023225; darn=freebsd.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=85jWj4DcWO5TYJGtsaRxJRLJs/KLVFUTWmhtt1h4w8s=; b=m2tDztfqH925q4DgvE3A5aUR6aYN93uwHvbGgtkY0suxxDIozWFo0TwRVza1U/XXH2 WWZFRQxBr9RwCaeW/l5fpNKtz1DXLYGulE/0faBobPf12r4dTbaVLUFh/ffnFTkgMNaS kg0XcIItkgA3+3rZw8HikCSuB45deAyeGm7NP6joWlN3fqP9cn9vzIjSzk55A9fS0FtD 72nTVXIZ9tlIJj2utAMMKBxYFashhQ982o1wnK6pLyMKoCetDuMUxkxjQ3VxWnPf7KEQ Hg8/VyhObcHbASn6OLMsBwcw6mjEJnoQuN6Fzqhv3eiEdkA64BusMAki0bBq8curmIyH CvGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752418425; x=1753023225; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=85jWj4DcWO5TYJGtsaRxJRLJs/KLVFUTWmhtt1h4w8s=; b=bUI8l+YQfTA9LvsNRQngAeFqOC46+ZyJPJVmwvqpoKdSOiut7kFQIFGJvl6ALp0O8V s2sUcyXC2NTjRxIe7j8t5GVUCBYFmhHNRzRJMwVx+j2rYAB6tZMRhcGC9Z8x+vtFP+JU u8esUfwEZOFEBiADd9W79lJHQMD4frEI1ZLIVkRcgyOoncSOAYoOTyTOTJ8Lcd+umbzM eZNl82BfSrlkjwBWJsiAEfwjZNCi6ovAoU5JPFybFd1SA+VT+pHytRhXx5Zo2Rbu+j3j 4vDCF4mPYnqiKb6bXBeD+EqjnfCdttkuo8lfqydaI9VXv+xUiR0b2rgq1E1JE70G8eLq 37jg== X-Forwarded-Encrypted: i=1; AJvYcCVF0TmCBBSEaJXMbYL2lkO49SZyWYkiH6MiXqwLzwFRn5hsnear8qecuIkJflpAVa1yhWafcI0OpCQ+DSInG+EGomZsJsA=@freebsd.org, AJvYcCXdj2l5GgBILi3Zh7MnN1hLiljF/5K6erUHvWHP1FBhqcs7P5OTyiWZbqhT5OPub4/b+FD6v21M2Bbd/q31KLCWFoUO@freebsd.org, AJvYcCXoyOha/UrGK7FcYthpyF1m3m+gNm5ZenbFjIv5hJ+rgc2YxtbaflhIPP4iYHrnj+0nyv/YrXjGWlK4D0xui58=@freebsd.org X-Gm-Message-State: AOJu0Yy/IEnyIuo3U90af3+vmS46Bo/rBbda8wjUf4EPLUKoEpj49kHx LtRqteIFUUqzQEU0BZRfRs0KqVVh6ZoTM4lSO76f5ocCb5hF9v3aJuOEZZJJnQ== X-Gm-Gg: ASbGncvhOpjcvaCF3yeYL1uflX9p3hBzG7yjCujnGsMAX2Y0xRBjORpt/nMAK/OLK9M p22so1bhpYchae1Ut+wUuucevPSBLx0Mr8+oTm67eGV8T3OUwvixBo5H+/2YC1VYVrOL5oWdka7 yADrg/aZ2iIsUlCk7ImsGzR3foeKsIdAk7Bb6NLzmXtl87wSMrBq78QmriPbUAAHLRTdJmaWtWD KS+kHiBTMiWaCTIbt0FCrBWgByPDINfFd3JlNG2IWMCZmr7YaScaJLO9GlnwJWdv+CSFtBhidTj KV1ccgpC3VRPUWjyFUaKRgv8IvcCjQ2s2zLHb5kVgYOsdxyBkBJ95PNrtIFASkcTowP462MAcBs k4nA9zuZQa7jC4RDUJkZSdPXWQmu4/A28M4Uw X-Google-Smtp-Source: AGHT+IGVzU8bgynvLLKciAu/3SE6v/7/CJmgUE8gjRcFnVuOn4hCJlTNZLmfdcvfAEcCRFR2XAlbdQ== X-Received: by 2002:a05:620a:4416:b0:7d4:635f:3e42 with SMTP id af79cd13be357-7debfcc7a3bmr1177998785a.20.1752418425118; Sun, 13 Jul 2025 07:53:45 -0700 (PDT) Received: from nuc (192-0-220-237.cpe.teksavvy.com. [192.0.220.237]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7dcde32bfcasm415715885a.65.2025.07.13.07.53.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Jul 2025 07:53:44 -0700 (PDT) Date: Sun, 13 Jul 2025 10:53:42 -0400 From: Mark Johnston To: Olivier Certner Cc: Charlie Li , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: f1f230439fa4 - main - vfs: Initial revision of inotify Message-ID: References: <202507041455.564EtqwS073424@gitrepo.freebsd.org> <2937929.UcPf6a0QyJ@francois> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2937929.UcPf6a0QyJ@francois> X-Rspamd-Queue-Id: 4bg7kR2CHXz3Vfb X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] On Sun, Jul 13, 2025 at 10:46:57PM +0900, Olivier Certner wrote: > Hi Charlie, > > The panic you're seeing is caused by 'MPASS(*eofflag != 0);' in vn_dir_next_dirent(). This test is here to check that VOP_READDIR() works properly. In particular, if VOP_READDIR() returned 0 (no error), and the length it filled is 0 (nothing was added), then we must be at EOF, and VOP_READDIR() must have set '*eofflag' to something non-zero. UFS has been verified to abide by this rule (unless the directory being read is malformed). Which filesystem are you using? > > Shot in the dark & educated guess: You're using ZFS, and you've just stumbled on the following case (lines from 'zfs_vnops_os.c'): > > /* > * Quit if directory has been removed (posix) > */ > if ((*eofp = zp->z_unlinked) != 0) { > zfs_exit(zfsvfs, FTAG); > return (0); > } > > which is a corner case that apparently has been missed. Just add some 'if (eofflag != NULL) *eofflag = 1;' inside the "then" block there and retry. It looks like all other cases in this function are handled correctly (but I have not thoroughly verified). The store to *eofp sets eofflag, so that is not the problem. Based on the presence of "efi" as a component name in the stack trace that Charlie provided, I suspect the problem is rather in msdosfs, but I don't immediately see what's wrong there. > I'll be mostly AFK for the next 10 days, so probably won't be able to follow-up, but hope that will help. > > Thanks and regards. > > -- > Olivier Certner