From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Aug 7 23:30:18 2006 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8E9C716A4F5 for ; Mon, 7 Aug 2006 23:30:18 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2AEC643D68 for ; Mon, 7 Aug 2006 23:30:17 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k77NUGKJ092920 for ; Mon, 7 Aug 2006 23:30:16 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k77NUGlo092916; Mon, 7 Aug 2006 23:30:16 GMT (envelope-from gnats) Resent-Date: Mon, 7 Aug 2006 23:30:16 GMT Resent-Message-Id: <200608072330.k77NUGlo092916@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Bartosz Fabianowski Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A8FF416A4DD for ; Mon, 7 Aug 2006 23:28:18 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5D18143D46 for ; Mon, 7 Aug 2006 23:28:18 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k77NSIRH047053 for ; Mon, 7 Aug 2006 23:28:18 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id k77NSIc4047052; Mon, 7 Aug 2006 23:28:18 GMT (envelope-from nobody) Message-Id: <200608072328.k77NSIc4047052@www.freebsd.org> Date: Mon, 7 Aug 2006 23:28:18 GMT From: Bartosz Fabianowski To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Cc: Subject: ports/101617: x11-themes/gtk-qt-engine option to disable libbonoboui support does nothing X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Aug 2006 23:30:18 -0000 >Number: 101617 >Category: ports >Synopsis: x11-themes/gtk-qt-engine option to disable libbonoboui support does nothing >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Aug 07 23:30:15 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Bartosz Fabianowski >Release: 6.1-STABLE >Organization: >Environment: FreeBSD takahe.local 6.1-STABLE FreeBSD 6.1-STABLE #0: Mon Jul 17 19:19:04 CEST 2006 root@takahe.local:/usr/obj/usr/src/sys/TAKAHE i386 >Description: Since version 0.7, x11-themes/gtk-qt-engine can optionally use and build-depend on x11-toolkits/libbonoboui. However, the option to enable or disable this does nothing and the dependency is unconditional. The attached patch fixes this. >How-To-Repeat: cd /usr/ports/x11-themes/gtk-qt-engine make WITHOUT_BONOBOUI -> x11-toolkits/libbonoboui is still checked for and built if not present >Fix: --- Makefile.orig Sat Aug 5 00:44:33 2006 +++ Makefile Tue Aug 8 01:27:27 2006 @@ -14,8 +14,7 @@ MAINTAINER= danny@ricin.com COMMENT= GTK-QT Theme Engine allows GTK2 apps to use QT (KDE) themes -LIB_DEPENDS= kdecore:${PORTSDIR}/x11/kdelibs3 \ - bonoboui-2:${PORTSDIR}/x11-toolkits/libbonoboui +LIB_DEPENDS= kdecore:${PORTSDIR}/x11/kdelibs3 USE_BZIP2= yes USE_GMAKE= yes @@ -30,6 +29,10 @@ CONFIGURE_ARGS+=--x-libraries=${X11BASE}/lib --x-includes=${X11BASE}/include OPTIONS= BONOBOUI "With libbonoboui (recommended)" on + +.if defined(WITH_BONOBOUI) +LIB_DEPENDS+= bonoboui-2:${PORTSDIR}/x11-toolkits/libbonoboui +.endif pre-configure: @${REINPLACE_CMD} -e "s|/share/themes/|/X11R6/share/themes/|" \ >Release-Note: >Audit-Trail: >Unformatted: