From owner-cvs-usrsbin Fri Jan 3 07:48:22 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id HAA28081 for cvs-usrsbin-outgoing; Fri, 3 Jan 1997 07:48:22 -0800 (PST) Received: from time.cdrom.com (time.cdrom.com [204.216.27.226]) by freefall.freebsd.org (8.8.4/8.8.4) with ESMTP id HAA28074; Fri, 3 Jan 1997 07:48:18 -0800 (PST) Received: from time.cdrom.com (localhost [127.0.0.1]) by time.cdrom.com (8.8.4/8.6.9) with ESMTP id HAA23464; Fri, 3 Jan 1997 07:48:00 -0800 (PST) To: joerg_wunsch@uriah.heep.sax.de (Joerg Wunsch) cc: jkh@freefall.freebsd.org (Jordan K. Hubbard), CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-usrsbin@freefall.freebsd.org Subject: Re: cvs commit: src/usr.sbin/syslogd syslogd.c In-reply-to: Your message of "Fri, 03 Jan 1997 11:49:03 +0100." Date: Fri, 03 Jan 1997 07:48:00 -0800 Message-ID: <23460.852306480@time.cdrom.com> From: "Jordan K. Hubbard" Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk I'll simply back this out of -current and 2.2 in the next few hours. No harm done, sorry - I wasn't aware of the savecore dependencies (how gross! :). If the syslogd death problem were easy to catch, we'd probably have it fixed by now tho.. :( > As Jordan K. Hubbard wrote: > > > jkh 97/01/02 23:13:23 > > > > Modified: usr.sbin/syslogd syslogd.c > > Log: > > Unlink LogName before attempting to open it. Since we now have a lovely > > bug in syslogd which causes it to die after random amounts of time (widel y > > reported), this at least allows the administrator to easily restart it > > without wondering why it simply exits again each time. > > This change is wrong. We've been there before, and deliberately > decided to keep the unlike out, and leave this to /etc/rc, or to the > admin to do it. Right now, you've broken logging from savecore(8) > which writes to the syslog socket before syslogd is running. sysylogd > used to be able to extract its messages from the socket buffer > previously (maybe months ago). > > Don't work around bugs by introducing new bugs. If syslogd dies, it > must be investigated. Mine didn't yet, but i've noticed: > > Jan 1 16:34:09 uriah syslogd: /dev/: Is a directory > Jan 1 16:34:09 uriah last message repeated 3 times > > ...without knowing what went wrong. > > Too bad that you've also instantly merged this to 2.2. Changes of > this kind should at least be discussed and run in -current for a week > or two before. > > -- > cheers, J"org > > joerg_wunsch@uriah.heep.sax.de -- http://www.sax.de/~joerg/ -- NIC: JW11-RIPE > Never trust an operating system you don't have sources for. ;-)