From owner-freebsd-rc@FreeBSD.ORG  Mon Dec 24 22:51:56 2012
Return-Path: <owner-freebsd-rc@FreeBSD.ORG>
Delivered-To: freebsd-rc@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 560A4E64
 for <freebsd-rc@FreeBSD.org>; Mon, 24 Dec 2012 22:51:56 +0000 (UTC)
 (envelope-from jilles@stack.nl)
Received: from mx1.stack.nl (relay02.stack.nl [IPv6:2001:610:1108:5010::104])
 by mx1.freebsd.org (Postfix) with ESMTP id E352D8FC0A
 for <freebsd-rc@FreeBSD.org>; Mon, 24 Dec 2012 22:51:52 +0000 (UTC)
Received: from snail.stack.nl (snail.stack.nl [IPv6:2001:610:1108:5010::131])
 by mx1.stack.nl (Postfix) with ESMTP id F03CE3592FD;
 Mon, 24 Dec 2012 23:51:50 +0100 (CET)
Received: by snail.stack.nl (Postfix, from userid 1677)
 id CDD472848C; Mon, 24 Dec 2012 23:51:50 +0100 (CET)
Date: Mon, 24 Dec 2012 23:51:50 +0100
From: Jilles Tjoelker <jilles@stack.nl>
To: Xin Li <delphij@delphij.net>
Subject: Re: conf/174595: /etc/rc.d/sysctl : unknown oid &#39; XXX&#39;
 [regression]
Message-ID: <20121224225150.GA81874@stack.nl>
References: <201212242220.qBOMK0um096595@freefall.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201212242220.qBOMK0um096595@freefall.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: freebsd-rc@FreeBSD.org
X-BeenThere: freebsd-rc@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Discussion related to /etc/rc.d design and implementation."
 <freebsd-rc.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-rc>,
 <mailto:freebsd-rc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-rc>
List-Post: <mailto:freebsd-rc@freebsd.org>
List-Help: <mailto:freebsd-rc-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-rc>,
 <mailto:freebsd-rc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Dec 2012 22:51:56 -0000

On Mon, Dec 24, 2012 at 10:20:00PM +0000, Xin Li wrote:
> The following reply was made to PR conf/174595; it has been noted by GNATS.

> From: Xin Li <delphij@delphij.net>
> To: bug-followup@FreeBSD.org, olivier@gid0.org
> Cc:  
> Subject: Re: conf/174595: /etc/rc.d/sysctl : unknown oid &#39;XXX&#39; [regression]
> Date: Mon, 24 Dec 2012 14:17:27 -0800

>  It seems that the old behavior is actually wrong...  How are we
>  benefited by not being told about fatal errors?

I think the old behaviour is correct.

How it used to work was that the first attempt via /etc/rc.d/sysctl
start would ignore nonexistent OIDs while the second attempt via
/etc/rc.d/sysctl lastload (via /etc/rc.d/securelevel) would complain
about them. This way, sysctls added by modules loaded via rc.d would be
harmlessly ignored the first time.

The new code attempts to do this via sysctl -i but appears to have
switched things around. Unknown OIDs should be ignored the first time
and should not be ignored the last time, which is the opposite the code
does.

-- 
Jilles Tjoelker