From owner-cvs-src@FreeBSD.ORG Sun Oct 1 20:37:21 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C942B16A403; Sun, 1 Oct 2006 20:37:21 +0000 (UTC) (envelope-from alc@cs.rice.edu) Received: from mail.cs.rice.edu (mail.cs.rice.edu [128.42.1.31]) by mx1.FreeBSD.org (Postfix) with ESMTP id DC95043D49; Sun, 1 Oct 2006 20:37:20 +0000 (GMT) (envelope-from alc@cs.rice.edu) Received: from mail.cs.rice.edu (localhost.localdomain [127.0.0.1]) by mail.cs.rice.edu (Postfix) with ESMTP id 9138F2C2B04; Sun, 1 Oct 2006 15:37:20 -0500 (CDT) X-Virus-Scanned: by amavis-2.4.0 at mail.cs.rice.edu Received: from mail.cs.rice.edu ([127.0.0.1]) by mail.cs.rice.edu (mail.cs.rice.edu [127.0.0.1]) (amavisd-new, port 10024) with LMTP id RCbs5gGhWmWk; Sun, 1 Oct 2006 15:37:20 -0500 (CDT) Received: from [216.63.78.18] (adsl-216-63-78-18.dsl.hstntx.swbell.net [216.63.78.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.cs.rice.edu (Postfix) with ESMTP id BDB192C2C0A; Sun, 1 Oct 2006 15:37:19 -0500 (CDT) Message-ID: <452026FF.9040000@cs.rice.edu> Date: Sun, 01 Oct 2006 15:37:19 -0500 From: Alan Cox User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.10) Gecko/20050817 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Martin Blapp References: <200609271810.k8RIAGSu022079@repoman.freebsd.org> <20061001191543.M91466@godot.imp.ch> In-Reply-To: <20061001191543.M91466@godot.imp.ch> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Alan Cox , cvs-src@FreeBSD.org, src-committers@FreeBSD.org, re@freesbd.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 pmap.c src/sys/i386/i386 pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Oct 2006 20:37:21 -0000 Martin Blapp wrote: > > Hi Alan, > > This commit makes my box crash with HEAD at startup. Please back it out > and investige why it happens. I'm pretty sure that it happens for > RELENG_6 too. > The assertion that fails for you under HEAD does not exist in RELENG_6. Have you seen a different assertion failure or crash in RELENG_6 since this patch was applied there? I will discuss this with re@. Regards, Alan > > > Martin Blapp, > ------------------------------------------------------------------ > ImproWare AG, UNIXSP & ISP, Zurlindenstrasse 29, 4133 Pratteln, CH > Phone: +41 61 826 93 00 Fax: +41 61 826 93 01 > PGP: > PGP Fingerprint: B434 53FC C87C FE7B 0A18 B84C 8686 EF22 D300 551E > ------------------------------------------------------------------ > > On Wed, 27 Sep 2006, Alan Cox wrote: > >> alc 2006-09-27 18:10:16 UTC >> >> FreeBSD src repository >> >> Modified files: (Branch: RELENG_6) >> sys/amd64/amd64 pmap.c >> sys/i386/i386 pmap.c >> Log: >> MFC >> Correct a very old and very obscure bug: vmspace_fork() calls >> pmap_copy() if the mapping is VM_INHERIT_SHARE. Suppose the mapping >> is also wired. vmspace_fork() clears the wiring attributes in the vm >> map entry but pmap_copy() copies the PG_W attribute in the PTE. I >> don't think this is catastrophic. It blocks pmap_remove_pages() from >> destroying the mapping and corrupts the pmap's wiring count. >> >> This revision fixes the problem by changing pmap_copy() to clear the >> PG_W attribute. >> >> Approved by: re (mux) >> >> Revision Changes Path >> 1.516.2.8 +4 -3 src/sys/amd64/amd64/pmap.c >> 1.523.2.8 +5 -3 src/sys/i386/i386/pmap.c >>