From owner-svn-src-head@freebsd.org Sat Nov 10 23:17:39 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A0725110E3C5; Sat, 10 Nov 2018 23:17:39 +0000 (UTC) (envelope-from woodsb02@gmail.com) Received: from mail-ua1-x930.google.com (mail-ua1-x930.google.com [IPv6:2607:f8b0:4864:20::930]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B80FB80F9E; Sat, 10 Nov 2018 23:17:38 +0000 (UTC) (envelope-from woodsb02@gmail.com) Received: by mail-ua1-x930.google.com with SMTP id z24so1882429ual.8; Sat, 10 Nov 2018 15:17:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pHwn6mzznwWvGz2bkmZSpDVdxq3HqFOKkbArIHfmx80=; b=fTkMUp6PU91cd++j8xiugXH6wHEK9RJfmKZZKRM4m6QgZxMuIIctcPGsWWY2ZaIWmP 8WNxX18pYEGoucud18aqPgSthyNICe7ECoL9U8Q3rX54ARwHsxYCt6JpzFmcRn3vU63H T6leirKGnod6nasHblmzWh4F60V7u1h6VXF1I+DfoFnSf+B2f9TFOrWal/o9laS/nYG8 QQYrF7sUCmXQNnUWyTCZkH+3q7/Jng0192JlY1DTFGidAQQ0YPEc8b5UX3FreSxbJFsl wJzuhCxjNN4WtfxeF3cttFM9RvCATU336BJ6iSEGJjRKXdOe518NGvxab+ajMpLx/sOX mYUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pHwn6mzznwWvGz2bkmZSpDVdxq3HqFOKkbArIHfmx80=; b=oYIpzhzIDsviwLmX6cKiwDR1zdhQPsGCBj1URMe8oP/+PGDpqbhj2FLknItXBdBx3N hJEBixV/Pt+niCa0EG+Eoz1tlF1PWZgAF8lWwyqY/mnxo/hfvIgawwSb+OKmImwrxAa8 es5jy7bT8FloGzV+TTw+ERZgFSwHAzSUmxnPYDZLNvhW/ZShsT/paIRWxA8wrVjM9Gks cbHjXxvqR6bwBTsFZGIV1AX69a6/Mg8dLfOA8xROGFXzwCFMAU+AfqmDPPLOt8l1M2UV UlYRZEEPiSCXK2jwCuYl43OV+5R7g1WyG2v1bdjVzg9yJT/YwrNJjWoVWCVWmzzc21N9 4Nlg== X-Gm-Message-State: AGRZ1gKL60IA7F8r5PsStIp5Bk5iNslZpX1TfOZDwIS6bZGadTk/q298 PKeWDqQjINp96SI0E4VuhbFNWAuIjjE3p5FYdYHvqw== X-Google-Smtp-Source: AJdET5d0nUEL8nAFNfUFJRhb8JvtOlJ9809kPVC2dE6heebur0CFuC9SynDm8D873YMtu1SH+TxTlNaRLEDdJafTHDo= X-Received: by 2002:a9f:386c:: with SMTP id q41mr6311304uad.27.1541891857902; Sat, 10 Nov 2018 15:17:37 -0800 (PST) MIME-Version: 1.0 References: <201811101658.wAAGw8Zd032024@repo.freebsd.org> <201811101843.wAAIhKrg016961@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <201811101843.wAAIhKrg016961@pdx.rh.CN85.dnsmgr.net> From: Ben Woods Date: Sun, 11 Nov 2018 07:17:27 +0800 Message-ID: Subject: Re: svn commit: r340326 - head To: rgrimes@freebsd.org Cc: Ben Woods , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: B80FB80F9E X-Spamd-Result: default: False [-4.86 / 200.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; R_DKIM_ALLOW(-0.20)[gmail.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCPT_COUNT_FIVE(0.00)[5]; IP_SCORE(-0.98)[ipnet: 2607:f8b0::/32(-2.89), asn: 15169(-1.93), country: US(-0.09)]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[0.3.9.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.86)[-0.863,0]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Server: mx1.freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Nov 2018 23:17:39 -0000 On Sun, 11 Nov 2018 at 2:43 am, Rodney W. Grimes < freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > If your going to bother with a differential, and invite people to > it you should give them at least 24 hours, and preferably 72 hours > to respond to the new review. Reviews that last < 4 hours are not > code reviews. > > -- > Rod Grimes > rgrimes@freebsd.org > Hi Rod, Sorry. The main reason I submitted the code review is because I do not have my src commit bit, so needed to seek approval to commit. I felt the need to commit the UPDATING entry was time sensitive, given the change it was notifying users of had already been committed. Regards, Ben -- -- From: Benjamin Woods woodsb02@gmail.com