From nobody Wed Jan 28 01:05:29 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f13wn6m7Xz6Prnt for ; Wed, 28 Jan 2026 01:05:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f13wn3jVTz3dhs for ; Wed, 28 Jan 2026 01:05:29 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769562329; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CEv2SLMdxws385Ow+eQFFUlp+C3zbmuqxmhgu4kfUJ4=; b=Yi3Hld0WHuzZXUoat2FCN1Dxf8vE2KQGEMW4XGyJN4j9Dgm9YC8VqJ3XkMjhrM3t0IA3f9 7/7Wx0ep/tWPi080TwJzDUhaM7E7Yayyzy37ErWCuWrKGpNvUMPf5Bk+u5jbgWrLbcGQz8 I5z+lKSwy50qsalV3DcKd7qpr/dU3xPAeZbTkKujC83CXlySx2/a+yFRvF4P60Agw+wG4I JpCx+NR23EEPRGfcluhaJhx6Zckfxv5Fa6aQEpyYI1MyFgBk4vIR50Oea7ZHGPSFsm1mfb UlLgocOL9/ipWdscZh+64XcJ1ORlfEYjL21BySlCCwD5lfNIsomA67lv6ajQnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769562329; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CEv2SLMdxws385Ow+eQFFUlp+C3zbmuqxmhgu4kfUJ4=; b=GVUuiekDpjULBpsl/3IDT7ncOccjZ7g1cenxskgOI3y6rL+q8F7E+GhdLcbMEDb3v/wqvY q/yaw6d+VhGbbFufEO/iT1k6vmwVPIPj5wXEOTT3NzGAlXjuHCjsUOucuRmKYGOGwmtX5e Bq1sIiE9rnhNPEg3TVPAXtP2QBRePU8L6iRrpMPi3Xd5Qsyih8+gOJ5ds3lDqplcpFCFr5 CYCPhQKXHyVzx13pex5N1REpPIiZGooPOUcr0ANCsNjVqI9q9+8tjY+ptLQyg378D83feu B+YDHUtM14NK87EXIo2rIlMAvVFLlqa3qBPqXT9tykgRj49eLODcOYL4aTT91A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1769562329; a=rsa-sha256; cv=none; b=qtBJunE7mfWPnFhyPtKViX2yAFSTYGObhepm24bhTPdxr93a0JJsJKXVZHiMS4IgPnJBUQ 1CkVko+ZqOttL4hAZh4i4HcaU4sh8+b7Nao9wmlumFd1zvOhsd0Nvc8kLyBBEz7Xh31CdG iOGySL1vvoH9TEYoBeGWPBhXG4Nv81+0E0ihX32fKv4FWQS8YWlrbj1FhtfWoeAsDdgY7W hKXpmPc6hsVVB8bjtc8jC4U8/Pe2jVBG1rcsW+EVUrFzQOdNp3gUCKzi2ZM7UYg3HdHKWv kOgFsfJnFJrcriQP2mViw09EXuRdY5FW39BSms1Ydf8xQV7MZ+nQa8YyUQ/XYQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f13wn2DQNzVsM for ; Wed, 28 Jan 2026 01:05:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id c1f2 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 28 Jan 2026 01:05:29 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Joseph Mingrone Subject: git: 1b3972ac0f75 - stable/14 - sh: Avoid referencing uninitialized memory in alias List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jrm X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 1b3972ac0f75c659afcd05574878cadaab4d61da Auto-Submitted: auto-generated Date: Wed, 28 Jan 2026 01:05:29 +0000 Message-Id: <697960d9.c1f2.761e35d9@gitrepo.freebsd.org> The branch stable/14 has been updated by jrm: URL: https://cgit.FreeBSD.org/src/commit/?id=1b3972ac0f75c659afcd05574878cadaab4d61da commit 1b3972ac0f75c659afcd05574878cadaab4d61da Author: Joseph Mingrone AuthorDate: 2025-05-15 14:42:14 +0000 Commit: Joseph Mingrone CommitDate: 2026-01-28 01:03:36 +0000 sh: Avoid referencing uninitialized memory in alias If run as alias '' uninitialized memory could be referenced. This is based on a fix from NetBSD. For more information, refer to https://github.com/NetBSD/src/commit/10cfed82c28 . Obtained from: NetBSD (Robert Elz , 10cfed82c28) MFC after: 3 days Reported by: mckusick, Robert Elz Reviewed by: emaste Differential Revision: https://reviews.freebsd.org/D50364 (cherry picked from commit 9d29fc2e4bfba9fcd3b0944e683458a3f1fa0c47) --- bin/sh/alias.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/bin/sh/alias.c b/bin/sh/alias.c index 4bac525e2678..a211cd1da3d5 100644 --- a/bin/sh/alias.c +++ b/bin/sh/alias.c @@ -210,6 +210,11 @@ aliascmd(int argc __unused, char **argv __unused) return (0); } while ((n = *argptr++) != NULL) { + if (n[0] == '\0') { + warning("'': not found"); + ret = 1; + continue; + } if ((v = strchr(n+1, '=')) == NULL) /* n+1: funny ksh stuff */ if ((ap = lookupalias(n, 0)) == NULL) { warning("%s: not found", n);