From owner-cvs-all Sun Jun 4 17:50:47 2000 Delivered-To: cvs-all@freebsd.org Received: from florence.pavilion.net (florence.pavilion.net [212.74.0.25]) by hub.freebsd.org (Postfix) with ESMTP id 7E2B937B85F; Sun, 4 Jun 2000 17:50:37 -0700 (PDT) (envelope-from joe@pavilion.net) Received: from genius.systems.pavilion.net (genesis.tao.org.uk [194.242.131.254]) by florence.pavilion.net (8.9.3/8.8.8) with ESMTP id BAA22051; Mon, 5 Jun 2000 01:50:36 +0100 (BST) (envelope-from joe@pavilion.net) Received: by genius.systems.pavilion.net (Postfix, from userid 100) id 0C304A6; Mon, 5 Jun 2000 01:50:53 +0100 (BST) Date: Mon, 5 Jun 2000 01:50:53 +0100 From: Josef Karthauser To: Doug Barton Cc: Warner Losh , "Matthew N. Dodd" , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/ls extern.h ls.1 ls.c ls.h print.c Message-ID: <20000605015052.J620@pavilion.net> References: <200006042215.QAA53873@harmony.village.org> <393ADBA7.7A2B5BF9@gorean.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2i In-Reply-To: <393ADBA7.7A2B5BF9@gorean.org>; from DougB@gorean.org on Sun, Jun 04, 2000 at 03:43:51PM -0700 X-NCC-RegID: uk.pavilion Organisation: Pavilion Internet plc, Lees House, 21-23 Dyke Road, Brighton, England Phone: +44-845-333-5000 Fax: +44-845-333-5001 Mobile: +44-403-596893 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sun, Jun 04, 2000 at 03:43:51PM -0700, Doug Barton wrote: > 2. The color options should be #ifdef'ed so that people who need a > slimmer ls can easily build one. (Thus anti-bloatists, picobsd, fixit > floppy people, etc.; can define "NOCOLORINLSNOWAYNOHOW" and be done with > it. :) Agreed. Although it should be NOJOENO :) > 3. First choice for 'ls -G' should be tgetstr(), with the ANSI codes > left in as a fallback if that returns NULL. (Thus handling the case of > no mounted /usr as well as possible.) No, if tgetstr returns NULL then there should be no colour. This is a must to avoid breaking non ANSI terminals. I've got a working patch for this. The only issue left is where in the code to initialise the termcap. Joe To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message