From nobody Wed Oct 29 11:15:56 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cxPn858Pqz6DXh2; Wed, 29 Oct 2025 11:15:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cxPn83XMbz47G2; Wed, 29 Oct 2025 11:15:56 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1761736556; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=z0wYc2RVfvcye5bNIA8aiMy97xhUmT7O9xl4MWtnlh8=; b=NtzC7sVCyY1EZpm8mib2hm3oLNolmzkuA2quc+NOmDSR3T05oDNCphcKb6ZU2mqOemaY8+ hLywElIuBQXPpoPabbZeT141MmQpchpjTM6m/PdgeuaDtpxcUCHST+tvD3dqhV37C9vkdG A6+ZvRrij/u7pCibYrh609RQ/J7UVqoYAa8aMJ3UPCi99nrUQ6d6JJ43z/P/f+q1BnVsp7 naq1Qu648Zh+uXMmz3AzEIElGhFNpqskzBlYw7lLU4aJQWzDXzCtJYMT7hxRnef9g6ozh9 HyvbBlZD3MCXIZ8MDi2OSFjW38dmExIyECPk/HNkUDw7r7lrPULQ0fY5BNNaDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1761736556; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=z0wYc2RVfvcye5bNIA8aiMy97xhUmT7O9xl4MWtnlh8=; b=XSnLoJrtzKJ80w5vcej8EqGiiOuVCMyx7rsBkvY39lgUFRFGaRWeUOe3p5mB1SQ3UQulGX RkDaJGBVjNv2l9amyWnBEzMO/Z2ajpJIpo5E3bvLDW1//cjIb8WVTGeDGp9CISqgGz+1p/ EC5NZL2ntNLBe/2uv+q+zvT2Lvavwd2KCy7NW66sd8V1GOledOjJcI0mzdlekgBSVEHBWM yTJL1FaiQtDlD2Llw7/ykw5d9P+Tbkis2Fr8821wMb76EPRZJ8MszetrJxibN71u3udNbL Osc5yXwMmJN03PB5Jlvvtf41gA4RK4qBVaYlZgqbeSGt194lH7Uam3PirB0E4Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1761736556; a=rsa-sha256; cv=none; b=FKR/oOFzIcp+TyQv23nborBXbMyd8IVizUUoIu30fVft8W3YO6BwHGMYyy3ImMpVsDzs2Z mZ9/ZLNGxOLFYWXvUOJhKdLx0vtDh7i6EEjFON2rWqgeyp3Rp/S42uFiwadeU6XgTgFZ56 taGtTSbgIkp74y+Sg9QJrS5Jmg6tDLKoV1b6XZ1w2biLhEcIAFBbeow4QK2cWdts+GHsXC 33sRqBKFc9cLcCSVwgn+uyWFlZS0NHtUSkEOxBShFINeSQNGu/Sr1zwzZ2EKtL13bv5SdG 6pyiuSQTKTz0cLWenxeZlDh+2xHg6z8GtkF3bdd6e6P2nQFEp91kZP6In+sgEw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cxPn82x9pzZjq; Wed, 29 Oct 2025 11:15:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 59TBFuDP042010; Wed, 29 Oct 2025 11:15:56 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 59TBFu7w042007; Wed, 29 Oct 2025 11:15:56 GMT (envelope-from git) Date: Wed, 29 Oct 2025 11:15:56 GMT Message-Id: <202510291115.59TBFu7w042007@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Robert Clausecker Subject: git: c824960b89af - stable/15 - sys/arm64: fix COMPAT_FREEBSD32 __syscall() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: fuz X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: c824960b89af082e5f083c0c4f141965d203eaa1 Auto-Submitted: auto-generated The branch stable/15 has been updated by fuz: URL: https://cgit.FreeBSD.org/src/commit/?id=c824960b89af082e5f083c0c4f141965d203eaa1 commit c824960b89af082e5f083c0c4f141965d203eaa1 Author: Robert Clausecker AuthorDate: 2025-10-21 21:35:24 +0000 Commit: Robert Clausecker CommitDate: 2025-10-29 11:15:21 +0000 sys/arm64: fix COMPAT_FREEBSD32 __syscall() It seems like _QUAD_LOWWORD was incorrectly expanded into 1, which is correct for big endian but not little endian. This means we always grab the padding word for the syscall number, which is usually 0, causing SIGSYS to be delivered to the caller. Reintroduce _QUAD_LOWWORD to fix the syscall. PR: 290411 MFC after: 1 week Discussed with: jrtc27 Reviewed by: cognet, emaste Approved by: markj (mentor) Fixes: 8c9c3144ccfa3061879b8cec015ee7d1010e4766 Differential Revision: https://reviews.freebsd.org/D53250 (cherry picked from commit 1ca09538d94273601dac08204c1d0b3ca9115864) --- sys/arm64/arm64/elf32_machdep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/arm64/arm64/elf32_machdep.c b/sys/arm64/arm64/elf32_machdep.c index 8f8a934ad520..4cb8ee5f57ef 100644 --- a/sys/arm64/arm64/elf32_machdep.c +++ b/sys/arm64/arm64/elf32_machdep.c @@ -210,7 +210,7 @@ freebsd32_fetch_syscall_args(struct thread *td) sa->code = *ap++; nap--; } else if (sa->code == SYS___syscall) { - sa->code = ap[1]; + sa->code = ap[_QUAD_LOWWORD]; nap -= 2; ap += 2; }