From nobody Sat Jun 28 05:08:38 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bTgTJ3j38z60kLT; Sat, 28 Jun 2025 05:09:40 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (mx.allbsd.org [131.112.84.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (secp384r1) client-digest SHA384) (Client CN "mail.allbsd.org", Issuer "E6" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bTgTH54yVz3NmJ; Sat, 28 Jun 2025 05:09:39 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Authentication-Results: mx1.freebsd.org; none Received-SPF: pass (mail.allbsd.org: authenticated connection) receiver=mail.allbsd.org; client-ip=2400:4051:a743:3c00:58:65ff:fe00:b0b; helo=mail-d.allbsd.org; envelope-from=hrs@FreeBSD.org; x-software=spfmilter 2.001 http://www.acme.com/software/spfmilter/ with libspf2-1.2.11; ARC-Seal: i=1; a=rsa-sha256; cv=none; d=allbsd.org; s=20250201; t= 1751087367; b=Z8xuGv5Z964s6u9d5iB1aS2KMIpzDHG3DV1lTx7NdxDMgANnEq 6xhKRegMl4GyI0bTXUfTAeoi2Pn0jlWj1ubmvmP4KzIhnHAUiSOEAPmKjKtwGAV9 ZoPCacMBrTh9XJ4Eze4S5UCX8WINhqtP+C8OTm6t/aN9zepZKcT13NOooZlxFAH8 dNrtxx5vw4lSuxOJIScb7xyGq+icdmPOowDHAwtu6rhRpi+lTCl0cMaOWrI1SkZO gXUsZXlX1OAmkdZiUIMGOnAFsburY64GoMWNqyH4AC2czqb6tfqDs81AJ0d3maYE hcwn+R6Yak3WjG5CFA3ZTAXny8OjC86QDFwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= allbsd.org; h=date:message-id:to:cc:subject:from:in-reply-to :references:mime-version:content-type:content-transfer-encoding; s=20250201; t=1751087367; bh=hgFNNXHGH3JgXgblYybfTCcVbnIrGbLUyj qcCPwW9Oc=; b=OgempfIKiFLUMRhW/aai2OGxk+WxvxRjL+n33VkS+Zjy1XHhEv TYtQmNMG8q/QQXACLqk2exMcW8pN2QXixgg3kBTndNXUnKlVVpo5UF6nWvHiOnOC MxKT0d5Ty8NG3/SYIpqwnbuD9YHi5vcg37CjSRKd0g9V6mVR9A1OTBwoWjBxRwlZ 0C3E+qqGtmXonBf/du91w/yGRRiVg9VhZKlyBAnP4/EiHfi0e+5IMqMqh9D6jqnD FlZQSd1ShwK9LVM+ON4V2Ei3KN6ThDTLMk9eRJA4/NN+XqG7pEJHrbzkvPLZwrI5 5rUKailMTqBCoQH22RZuRIAa7HvnCwuxHFIw== ARC-Authentication-Results: i=1; mail.allbsd.org; arc=none (no signatures found); auth=pass; dkim=none (no signatures found); smime=none; x-return-mx=pass header.domain=freebsd.org policy.is_org=yes (MX Records found: mx66.freebsd.org,mx1.freebsd.org); x-return-mx=pass smtp.domain=freebsd.org policy.is_org=yes (MX Records found: mx66.freebsd.org,mx1.freebsd.org) Received: from mail-d.allbsd.org ([IPv6:2400:4051:a743:3c00:58:65ff:fe00:b0b]) (authenticated bits=56) by mail.allbsd.org (8.18.1/8.18.1) with ESMTPSA id 55S59PwT054302 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=OK) (Client CN "/CN=mail-d.allbsd.org", Issuer "/C=US/O=Let's+20Encrypt/CN=E6"); Sat, 28 Jun 2025 14:09:27 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from alph.d.allbsd.org ([IPv6:2400:4051:a743:3c00:5a9c:fcff:fe10:ffc2]) by mail-d.allbsd.org (8.18.1/8.16.1) with ESMTPS id 55S59NIk050914 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sat, 28 Jun 2025 14:09:23 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (localhost [[UNIX: localhost]]) (authenticated bits=0) by alph.d.allbsd.org (8.18.1/8.16.1) with ESMTPA id 55S59KpI050910; Sat, 28 Jun 2025 14:09:21 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Sat, 28 Jun 2025 14:08:38 +0900 (JST) Message-Id: <20250628.140838.1632734946851803211.hrs@FreeBSD.org> To: markj@freebsd.org, glebius@freebsd.org Cc: bapt@freebsd.org, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, srcmgr@freebsd.org Subject: Re: git: 4deb9760a9d8 - main - rc: Disable pathname expansion when calling run_rc_command() From: Hiroki Sato In-Reply-To: References: X-Old-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-PGPkey-fingerprint: 6C0D 2353 27CF 80C7 901E FDD2 DBB0 7DC6 6F1F 737F X-Mailer: Mew version 6.8 on Emacs 29.4 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha512; boundary="--Security_Multipart(Sat_Jun_28_14_08_38_2025_065)--" Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.4 (mail.allbsd.org [IPv6:2402:3d00:fb5d:8001:0:0:0:41]); Sat, 28 Jun 2025 14:09:27 +0900 (JST) X-Rspamd-Queue-Id: 4bTgTH54yVz3NmJ X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:9367, ipnet:131.112.0.0/16, country:JP] ----Security_Multipart(Sat_Jun_28_14_08_38_2025_065)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mark Johnston wrote in : ma> On Fri, Jun 27, 2025 at 12:37:52PM -0700, Gleb Smirnoff wrote: ma> > On Fri, Jun 27, 2025 at 08:56:23PM +0200, Baptiste Daroussin wrote: ma> > B> On Wed 18 Jun 10:13, Mark Johnston wrote: ma> > B> > On Thu, Jun 12, 2025 at 06:20:26PM +0000, Hiroki Sato wrote: ma> > B> > > The branch main has been updated by hrs: ma> > B> > > ma> > B> > > URL: https://cgit.FreeBSD.org/src/commit/?id=4deb9760a9d84d5861ee45162ffebe83f13503b8 ma> > B> > > ma> > B> > > commit 4deb9760a9d84d5861ee45162ffebe83f13503b8 ma> > B> > > Author: Hiroki Sato ma> > B> > > AuthorDate: 2025-06-12 18:19:32 +0000 ma> > B> > > Commit: Hiroki Sato ma> > B> > > CommitDate: 2025-06-12 18:19:32 +0000 ma> > B> > > ma> > B> > > rc: Disable pathname expansion when calling run_rc_command() ma> > B> > > ma> > B> > > Variables for command-line options like $foo_flags can contain characters ma> > B> > > that perform pathname expansions, such as '[', ']', and '*'. They were ma> > B> > > passed without escaping, and the matched entries in the working directory ma> > B> > > affected the command-line options. This change turns off the expansion ma> > B> > > when run_rc_command() is called. ma> > B> > > ma> > B> > > While this changes the current behavior, an invocation of a service ma> > B> > > program should not depend on entries in the working directory. ma> > B> > ma> > B> > This also turns off globbing for /etc/rc.local, which broke one of my ma> > B> > scripts. Was that intentional? If so, we should really document it in ma> > B> > RELNOTES at the very least. ma> > B> ma> > B> This broke nuageinit which rely on globbing to in nuageinit_start, that this ma> > B> change also broke. ma> > B> ma> > B> So many downstream CI are now broken, due to this change. ma> > ma> > Given that Hiroki is not reacting on this email thread neither in ma> > https://reviews.freebsd.org/D51043, I would like to revert this change. I'd ma> > like also remind that the problem was discovered during the stabweek testing. ma> > Although we thawed the freeze, but we are still working on a good known stable ma> > revision for June. ma> > ma> > Any objections? ma> > ma> > Adding srcmgr@ ma> ma> I've reverted the change (and a follow-up fix) for now. I am sorry for not responding in a timely manner. I overlooked the impact and needed to revert it promptly. The original problem with globbing still remains, so I will submit another patch for review shortly. -- Hiroki ----Security_Multipart(Sat_Jun_28_14_08_38_2025_065)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iMgEABMKAC4WIQRsDSNTJ8+Ax5Ae/dLbsH3Gbx9zfwUCaF941hAcaHJzQGZyZWVi c2Qub3JnAAoJENuwfcZvH3N/eHsCCIx24qwcu54+4PS4geIqRBz3/7KrQbzlN6no UZS2d5/TE5jtyCZL3b15LC2IbRe2rCrgKjFwgWoIgB+4Qzsb2wA2AgixvAvvVa+i r6yrnfq787/CCAQqElk0fRFTXSKHexo1LzR/aPjHGWFM8NxGw/S5wcOyX751GFod gBMXED06SqXaNw== =T1Bg -----END PGP SIGNATURE----- ----Security_Multipart(Sat_Jun_28_14_08_38_2025_065)----