From owner-svn-ports-head@freebsd.org Thu Oct 8 14:40:54 2015 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DDE5F9D1594; Thu, 8 Oct 2015 14:40:54 +0000 (UTC) (envelope-from amdmi3@amdmi3.ru) Received: from vps.amdmi3.ru (vps.amdmi3.ru [109.234.38.216]) by mx1.freebsd.org (Postfix) with ESMTP id 1714DA35; Thu, 8 Oct 2015 14:40:54 +0000 (UTC) (envelope-from amdmi3@amdmi3.ru) Received: from hive.panopticon (unknown [78.153.152.119]) by vps.amdmi3.ru (Postfix) with ESMTPS id 0E696B0620; Thu, 8 Oct 2015 17:40:47 +0300 (MSK) Received: from hades.panopticon (hades.panopticon [192.168.0.32]) by hive.panopticon (Postfix) with ESMTP id D0DDD5CE; Thu, 8 Oct 2015 17:37:00 +0300 (MSK) Received: by hades.panopticon (Postfix, from userid 1000) id 171155A7; Thu, 8 Oct 2015 17:39:44 +0300 (MSK) Date: Thu, 8 Oct 2015 17:39:44 +0300 From: Dmitry Marakasov To: Baptiste Daroussin Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r398821 - head/security/maia Message-ID: <20151008143944.GG68979@hades.panopticon> References: <201510081319.t98DJg1g056186@repo.freebsd.org> <20151008132645.GJ91729@ivaldir.etoilebsd.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20151008132645.GJ91729@ivaldir.etoilebsd.net> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Oct 2015 14:40:55 -0000 * Baptiste Daroussin (bapt@FreeBSD.org) wrote: > > Author: amdmi3 > > Date: Thu Oct 8 13:19:42 2015 > > New Revision: 398821 > > URL: https://svnweb.freebsd.org/changeset/ports/398821 > > > > Log: > > - Move file owner handling to plist, fix stage as non-root > > > > PR: 203287 > > Submitted by: amdmi3 > > Approved by: maintainer timeout (ek@purplehat.org, 2 weeks) > > > > Modified: > > head/security/maia/Makefile > > head/security/maia/pkg-plist > > > > Modified: head/security/maia/Makefile > > ============================================================================== > > --- head/security/maia/Makefile Thu Oct 8 12:56:37 2015 (r398820) > > +++ head/security/maia/Makefile Thu Oct 8 13:19:42 2015 (r398821) > > @@ -338,7 +338,6 @@ post-patch: > > do-install: > > ${MKDIR} ${STAGEDIR}${WWWDIR} > > @cd ${WRKSRC}/php && ${COPYTREE_SHARE} . ${STAGEDIR}${WWWDIR} > > - ${CHOWN} -R ${WWWOWN}:${WWWGRP} ${STAGEDIR}${WWWDIR}/ > > ${LN} -s ${PREFIX}/share/smarty ${STAGEDIR}${WWWDIR}/libs/Smarty > > ${MKDIR} -p ${STAGEDIR}${DATADIR} > > @cd ${WRKSRC}/scripts && ${COPYTREE_SHARE} . ${STAGEDIR}${DATADIR}/scripts > > @@ -350,11 +349,10 @@ do-install: > > ${INSTALL} -m 640 ${WRKSRC}/maiad.conf.dist ${STAGEDIR}${ETCDIR}/maiad.conf.dist > > ${INSTALL} -m 640 ${WRKSRC}/maia.conf.dist ${STAGEDIR}${ETCDIR}/maia.conf.dist > > > > -.if ${PORT_OPTIONS:MDOCS} > > +do-install-DOCS-on: > > ${MKDIR} ${STAGEDIR}${DOCSDIR} > > .for i in ${DOCS} > > ${INSTALL_DATA} ${WRKSRC}/${i} ${STAGEDIR}${DOCSDIR} > > .endfor > > -.endif > > > > .include > > > > Modified: head/security/maia/pkg-plist > > ============================================================================== > > --- head/security/maia/pkg-plist Thu Oct 8 12:56:37 2015 (r398820) > > +++ head/security/maia/pkg-plist Thu Oct 8 13:19:42 2015 (r398821) > > @@ -40,6 +40,8 @@ sbin/maiad > > %%DATADIR%%/scripts/send-quarantine-reminders.pl > > %%DATADIR%%/scripts/stats-snapshot.pl > > @mode > > +@owner %%WWWOWN%% > > +@group %%WWWGRP%% > > There is absolutly no reason those files belongs to those users only directories > (like cache directories) and files that the app expect to be able to modified > when run should be own by such user, otherwise everything should belong to > root/wheel: aka the default I know, and there's ton of ports like that. However my task currently is to fix stage-qa problems and packaging as non-root, so I do not change owner/group scope. Permissions should be fixed by maintainers. -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://amdmi3.ru