From nobody Tue Oct 3 07:35:34 2023 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S08kQ6vg2z4vv5w; Tue, 3 Oct 2023 07:35:42 +0000 (UTC) (envelope-from meta@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S08kQ6PMZz3LgN; Tue, 3 Oct 2023 07:35:42 +0000 (UTC) (envelope-from meta@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696318542; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0jCl+SSnFSiRUg4MdFUdNq3rFpPefY2u2tNVRjVony0=; b=J39dRjMJz84YJZItSr97KNU7m7pTeswQpcWqn0XYFPM7lyWWl3aRuSD1otnv3KcQc8naOG lCjxa6uCSkD6uUHtjuRdrRIRMMcipxcBqRuLtSmibHRYN1xapX85HFiaN79RUB18id/Nw9 lhYvDKS5QAoEZql7IVgbuM5BUHYMFO38+Y7gKEFECFD/mXD8znXeYJQzmyl19aQXNvSRmX Dpr6WtSZn6HckSCRv4ww/BN7cZQPPOD5gsQRr0r3/pqaYS+tpvwHsKnB5Nuc6kuV5B46bf uE8KRsHf4MbA3oqYZQ9BDHfVNrH2iEzUHGL/zdnwppdAs9MbLp8pd/x2KNWH2w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1696318542; a=rsa-sha256; cv=none; b=U9EMhYahi+r7Nv6aeiUVEQ0e2FIVOvRCRQzcaNOyl6P2guu+CvuLchypiNNwbTFXW7MZJb 5A+VTuyNUgQugIogFSWaqwpH5doI/QXHS/IGy3NXxBj9j7XnFGZYdsxxAkjZu717mymYtx VWHPXizqqhtaK7z0t+opbQbGLsKxOVBMmPhWva60z0wMCSmAERSsf+otkhAVAlwe9VJO49 tvq3bxZ75Koq6PtD1JOxKGGOSkjIbNknLdLW9SX+sKGNg33Go+/mSfOvlt9dbcVb1Ozmag iYK7iQOR6LoNRtCdCHWdVv4b/n4k9ASpaG/i49Zibkfg3mQpK/un7lPVhzEXwg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696318542; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0jCl+SSnFSiRUg4MdFUdNq3rFpPefY2u2tNVRjVony0=; b=U3sJjvVNhdD+KIq4Xi77841Sj/Hf5Au1YmU2p4IlFAo6SLbwzgqDDJcWeNu9R0bnK3D0bp yuE/jtTqY1JCfDrvkd3ftsTJT2rzPMMlLUtgOfZ4JvvJle8MnU9EmwJ5L54baSv8PrHMbO 4xHDoxd5c5E9Z2v+o4pp8NCPczU6RrrtLwSLKMKYd9AoEJpyueZe17cEOtvmQUlz09X309 LzoAovo4ukLtw4fYJ+sDDfNuN1flxtBDc/VBHANgjagZ+iPu4LjKwme43OLRi+l7xX3v1N s4uKHM7n4yzKM+Vq5/fB3GL9lhWw2akj2G5QzQKxa2HaDx2VVSk6JGiMOKruww== Received: from icepick.vmeta.jp (unknown [IPv6:2403:bd80:c100:401:c970:1537:77b6:dfde]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: meta/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4S08kP2Dngzq0j; Tue, 3 Oct 2023 07:35:41 +0000 (UTC) (envelope-from meta@freebsd.org) Date: Tue, 3 Oct 2023 16:35:34 +0900 From: Koichiro Iwao To: Daniel Engberg Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: d1266382c292 - main - benchmarks/unixbench: Remove custom optimization and clean up Makefile Message-ID: X-Operating-System: FreeBSD 13.2-STABLE amd64 References: <202310021950.392JoHfr028322@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <202310021950.392JoHfr028322@gitrepo.freebsd.org> Hi, have you test the build? On Mon, Oct 02, 2023 at 07:50:17PM +0000, Daniel Engberg wrote: > The branch main has been updated by diizzy: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=d1266382c292f5f6731f0e29591cabbbd13f9f93 > > commit d1266382c292f5f6731f0e29591cabbbd13f9f93 > Author: Daniel Engberg > AuthorDate: 2023-09-30 21:32:02 +0000 > Commit: Daniel Engberg > CommitDate: 2023-10-02 19:50:13 +0000 > > benchmarks/unixbench: Remove custom optimization and clean up Makefile > > * Define LICENSE_FILE > * Use USES= localbase:ldflags helper > * Drop OPTIMIZED_CFLAGS > * Some changes to Makefile to improve readability > > PR: 272705 > Reviewed by: pizzamig (maintainer) > --- > benchmarks/unixbench/Makefile | 21 +++++++++------------ > 1 file changed, 9 insertions(+), 12 deletions(-) > > diff --git a/benchmarks/unixbench/Makefile b/benchmarks/unixbench/Makefile > index 71b578e03425..4cfcae1b486d 100644 > --- a/benchmarks/unixbench/Makefile > +++ b/benchmarks/unixbench/Makefile > @@ -2,7 +2,7 @@ PORTNAME= unixbench > DISTVERSIONPREFIX= v > DISTVERSION= 5.1.3-51 > DISTVERSIONSUFFIX= -g6705203 > -PORTREVISION= 1 > +PORTREVISION= 2 > CATEGORIES= benchmarks > > MAINTAINER= pizzamig@FreeBSD.org > @@ -10,27 +10,24 @@ COMMENT= BYTE magazine's Public Domain benchmark for UNIX > WWW= https://github.com/kdlucas/byte-unixbench > > LICENSE= GPLv2 > +LICENSE_FILE= ${WRKSRC}/LICENSE.txt > > RUN_DEPENDS= x11perf:x11/x11perf > > -USES= gmake gl perl5 shebangfix xorg > +USES= gmake gl localbase:ldflags perl5 shebangfix xorg > +USE_GL= gl > +SHEBANG_FILES= Run pgms/gfx-x11 > +USE_XORG= x11 xext > + > USE_GITHUB= yes > GH_ACCOUNT= kdlucas > GH_PROJECT= byte-unixbench > + > WRKSRC_SUBDIR= UnixBench > -USE_GL= gl > -USE_XORG= x11 xext > -CFLAGS+= -I${LOCALBASE}/include \ > - -L${LOCALBASE}/lib > > -OPTIONS_DEFINE= OPTIMIZED_CFLAGS > -OPTIONS_EXCLUDE_aarch64= OPTIMIZED_CFLAGS > -MAKE_ENV= "UB_GCC_OPTIONS=-O3 -ffast-math -fomit-frame-pointer" > -#march generates code that can be incompatibe with previous CPU generations > -OPTIMIZED_CFLAGS_MAKE_ENV= "UB_GCC_OPTIONS=-O3 -ffast-math -fomit-frame-pointer -march=native" > +MAKE_ENV= UB_GCC_OPTIONS=" " > > SUB_FILES= unixbench > -SHEBANG_FILES= Run pgms/gfx-x11 > > post-patch: > ${REINPLACE_CMD} -e 's/^CC=gcc/#CC=gcc/' ${WRKSRC}/Makefile -- meta