From owner-freebsd-ports-bugs@FreeBSD.ORG Sat May 12 14:30:17 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id CF1931065676 for ; Sat, 12 May 2012 14:30:17 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id A798A8FC23 for ; Sat, 12 May 2012 14:30:17 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q4CEUHKw078176 for ; Sat, 12 May 2012 14:30:17 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q4CEUHa1078173; Sat, 12 May 2012 14:30:17 GMT (envelope-from gnats) Resent-Date: Sat, 12 May 2012 14:30:17 GMT Resent-Message-Id: <201205121430.q4CEUHa1078173@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dmitry Afanasiev Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E3A401065670 for ; Sat, 12 May 2012 14:26:55 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id B51378FC0C for ; Sat, 12 May 2012 14:26:55 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q4CEQt83060147 for ; Sat, 12 May 2012 14:26:55 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id q4CEQsaX060146; Sat, 12 May 2012 14:26:54 GMT (envelope-from nobody) Message-Id: <201205121426.q4CEQsaX060146@red.freebsd.org> Date: Sat, 12 May 2012 14:26:54 GMT From: Dmitry Afanasiev To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/167824: mail/dovecot: double checks for build options X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 May 2012 14:30:18 -0000 >Number: 167824 >Category: ports >Synopsis: mail/dovecot: double checks for build options >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat May 12 14:30:17 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Dmitry Afanasiev >Release: FreeBSD 9.0-STABLE amd64 >Organization: >Environment: FreeBSD sunweb.elcom.spb.ru 9.0-STABLE FreeBSD 9.0-STABLE #1: Mon Mar 5 12:52:03 MSK 2012 root@sunweb:/usr/obj/usr/src/sys/sunweb amd64 >Description: Build options in Makefile are double checked like this: .if defined(WITH_SSL) && !defined(WITHOUT_SSL) and options can't be overridden by make.conf with simple string: WITH_SSL=yes Please remove double checks for users who want to control options via make.conf. >How-To-Repeat: >Fix: --- Makefile.orig 2012-05-12 18:15:05.199347705 +0400 +++ Makefile 2012-05-12 18:25:44.161344971 +0400 @@ -90,7 +90,7 @@ ## SSL support # -.if defined(WITH_SSL) && !defined(WITHOUT_SSL) +.if defined(WITH_SSL) PROTOCOLS+= imaps pop3s .else CONFIGURE_ARGS+= --without-ssl @@ -98,7 +98,7 @@ ## ManageSieve support # -.if defined(WITH_MANAGESIEVE) && !defined(WITHOUT_MANAGESIEVE) +.if defined(WITH_MANAGESIEVE) MANAGESIEVEVERSION!= ${MAKE} -C ${.CURDIR}/../dovecot-managesieve -V PORTVERSION PATCH_SITES!= ${MAKE} -C ${.CURDIR}/../dovecot-managesieve -V MASTER_SITES PATCHFILES+= dovecot-${PORTVERSION}-managesieve-${MANAGESIEVEVERSION}.diff.gz @@ -109,7 +109,7 @@ ## GSSAPI support # -.if defined(WITH_GSSAPI) && !defined(WITHOUT_GSSAPI) +.if defined(WITH_GSSAPI) CONFIGURE_ARGS+= --with-gssapi .else CONFIGURE_ARGS+= --without-gssapi @@ -117,7 +117,7 @@ ## VPopMail Support # -.if defined(WITH_VPOPMAIL) && !defined(WITHOUT_VPOPMAIL) +.if defined(WITH_VPOPMAIL) VPOPMAIL= ${LOCALBASE}/vpopmail/bin/vchkpw BUILD_DEPENDS+= ${VPOPMAIL}:${PORTSDIR}/mail/vpopmail CONFIGURE_ARGS+= --with-vpopmail @@ -127,7 +127,7 @@ ## BDB Support # -.if defined(WITH_BDB) && !defined(WITHOUT_BDB) +.if defined(WITH_BDB) USE_BDB= 42+ CONFIGURE_ARGS+= --with-db CFLAGS+= -I${BDB_INCLUDE_DIR} -L${BDB_LIB_DIR} @@ -139,7 +139,7 @@ ## OpenLDAP Support # -.if defined(WITH_LDAP) && !defined(WITHOUT_LDAP) +.if defined(WITH_LDAP) USE_OPENLDAP= yes CONFIGURE_ARGS+= --with-ldap PLIST_SUB+= LDAP="" @@ -151,7 +151,7 @@ ## PostgreSQL Support # -.if defined(WITH_PGSQL) && !defined(WITHOUT_PGSQL) +.if defined(WITH_PGSQL) USE_PGSQL= yes CONFIGURE_ARGS+= --with-pgsql PLIST_SUB+= SQL="" @@ -163,7 +163,7 @@ ## MySQL Support # -.if defined(WITH_MYSQL) && !defined(WITHOUT_MYSQL) +.if defined(WITH_MYSQL) USE_MYSQL= yes CONFIGURE_ARGS+= --with-mysql PLIST_SUB+= SQL="" @@ -175,7 +175,7 @@ ## SQLite Support # -.if defined(WITH_SQLITE) && !defined(WITHOUT_SQLITE) +.if defined(WITH_SQLITE) USE_SQLITE= 3 CONFIGURE_ARGS+= --with-sqlite PLIST_SUB+= SQL="" >Release-Note: >Audit-Trail: >Unformatted: