Date: Sat, 12 May 2012 14:26:54 GMT From: Dmitry Afanasiev <KOT@MATPOCKuH.Ru> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/167824: mail/dovecot: double checks for build options Message-ID: <201205121426.q4CEQsaX060146@red.freebsd.org> Resent-Message-ID: <201205121430.q4CEUHa1078173@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 167824
>Category: ports
>Synopsis: mail/dovecot: double checks for build options
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sat May 12 14:30:17 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: Dmitry Afanasiev
>Release: FreeBSD 9.0-STABLE amd64
>Organization:
>Environment:
FreeBSD sunweb.elcom.spb.ru 9.0-STABLE FreeBSD 9.0-STABLE #1: Mon Mar 5 12:52:03 MSK 2012 root@sunweb:/usr/obj/usr/src/sys/sunweb amd64
>Description:
Build options in Makefile are double checked like this:
.if defined(WITH_SSL) && !defined(WITHOUT_SSL)
and options can't be overridden by make.conf with simple string:
WITH_SSL=yes
Please remove double checks for users who want to control options via make.conf.
>How-To-Repeat:
>Fix:
--- Makefile.orig 2012-05-12 18:15:05.199347705 +0400
+++ Makefile 2012-05-12 18:25:44.161344971 +0400
@@ -90,7 +90,7 @@
## SSL support
#
-.if defined(WITH_SSL) && !defined(WITHOUT_SSL)
+.if defined(WITH_SSL)
PROTOCOLS+= imaps pop3s
.else
CONFIGURE_ARGS+= --without-ssl
@@ -98,7 +98,7 @@
## ManageSieve support
#
-.if defined(WITH_MANAGESIEVE) && !defined(WITHOUT_MANAGESIEVE)
+.if defined(WITH_MANAGESIEVE)
MANAGESIEVEVERSION!= ${MAKE} -C ${.CURDIR}/../dovecot-managesieve -V PORTVERSION
PATCH_SITES!= ${MAKE} -C ${.CURDIR}/../dovecot-managesieve -V MASTER_SITES
PATCHFILES+= dovecot-${PORTVERSION}-managesieve-${MANAGESIEVEVERSION}.diff.gz
@@ -109,7 +109,7 @@
## GSSAPI support
#
-.if defined(WITH_GSSAPI) && !defined(WITHOUT_GSSAPI)
+.if defined(WITH_GSSAPI)
CONFIGURE_ARGS+= --with-gssapi
.else
CONFIGURE_ARGS+= --without-gssapi
@@ -117,7 +117,7 @@
## VPopMail Support
#
-.if defined(WITH_VPOPMAIL) && !defined(WITHOUT_VPOPMAIL)
+.if defined(WITH_VPOPMAIL)
VPOPMAIL= ${LOCALBASE}/vpopmail/bin/vchkpw
BUILD_DEPENDS+= ${VPOPMAIL}:${PORTSDIR}/mail/vpopmail
CONFIGURE_ARGS+= --with-vpopmail
@@ -127,7 +127,7 @@
## BDB Support
#
-.if defined(WITH_BDB) && !defined(WITHOUT_BDB)
+.if defined(WITH_BDB)
USE_BDB= 42+
CONFIGURE_ARGS+= --with-db
CFLAGS+= -I${BDB_INCLUDE_DIR} -L${BDB_LIB_DIR}
@@ -139,7 +139,7 @@
## OpenLDAP Support
#
-.if defined(WITH_LDAP) && !defined(WITHOUT_LDAP)
+.if defined(WITH_LDAP)
USE_OPENLDAP= yes
CONFIGURE_ARGS+= --with-ldap
PLIST_SUB+= LDAP=""
@@ -151,7 +151,7 @@
## PostgreSQL Support
#
-.if defined(WITH_PGSQL) && !defined(WITHOUT_PGSQL)
+.if defined(WITH_PGSQL)
USE_PGSQL= yes
CONFIGURE_ARGS+= --with-pgsql
PLIST_SUB+= SQL=""
@@ -163,7 +163,7 @@
## MySQL Support
#
-.if defined(WITH_MYSQL) && !defined(WITHOUT_MYSQL)
+.if defined(WITH_MYSQL)
USE_MYSQL= yes
CONFIGURE_ARGS+= --with-mysql
PLIST_SUB+= SQL=""
@@ -175,7 +175,7 @@
## SQLite Support
#
-.if defined(WITH_SQLITE) && !defined(WITHOUT_SQLITE)
+.if defined(WITH_SQLITE)
USE_SQLITE= 3
CONFIGURE_ARGS+= --with-sqlite
PLIST_SUB+= SQL=""
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201205121426.q4CEQsaX060146>