From owner-svn-src-head@freebsd.org Mon Aug 31 08:43:38 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7AC859C7E43; Mon, 31 Aug 2015 08:43:38 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0D4E4118D; Mon, 31 Aug 2015 08:43:37 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id t7V8hX2F053589 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Mon, 31 Aug 2015 11:43:33 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua t7V8hX2F053589 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id t7V8hXc6053588; Mon, 31 Aug 2015 11:43:33 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 31 Aug 2015 11:43:33 +0300 From: Konstantin Belousov To: Adrian Chadd Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r287312 - head/sys/dev/iwn Message-ID: <20150831084333.GP2072@kib.kiev.ua> References: <201508302154.t7ULsXaT070453@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201508302154.t7ULsXaT070453@repo.freebsd.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Aug 2015 08:43:38 -0000 On Sun, Aug 30, 2015 at 09:54:33PM +0000, Adrian Chadd wrote: > static int > -iwn_ioctl(struct ieee80211com *ic, u_long cmd, void *data) > +iwn_cdev_open(struct cdev *dev, int flags, int type, struct thread *td) > { > - struct ifreq *ifr = data; > - struct iwn_softc *sc = ic->ic_softc; > - int error = 0; > - > + > + return (0); > +} > + > +static int > +iwn_cdev_close(struct cdev *dev, int flags, int type, struct thread *td) > +{ > + > + return (0); > +} devfs does the right thing for drivers which does not provide d_open and d_close methods, these empty stubs are not needed.