From owner-freebsd-current@FreeBSD.ORG Tue Jul 12 07:49:16 2011 Return-Path: Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7AD5C1065670 for ; Tue, 12 Jul 2011 07:49:16 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id BC0188FC0C for ; Tue, 12 Jul 2011 07:49:15 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id KAA06358; Tue, 12 Jul 2011 10:49:12 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1QgXiS-000Pja-Fr; Tue, 12 Jul 2011 10:49:12 +0300 Message-ID: <4E1BFC77.6080203@FreeBSD.org> Date: Tue, 12 Jul 2011 10:49:11 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:5.0) Gecko/20110706 Thunderbird/5.0 MIME-Version: 1.0 To: Arnaud Lacombe References: <4E1421D9.7080808@zedat.fu-berlin.de> <4E147F54.40908@zedat.fu-berlin.de> <20110706162811.GA68436@troutmask.apl.washington.edu> <20110706193636.GA69550@troutmask.apl.washington.edu> <4E14CCE5.4050906@zedat.fu-berlin.de> <20110707015151.GB71966@troutmask.apl.washington.edu> <4E1B67C7.8040402@FreeBSD.org> In-Reply-To: X-Enigmail-Version: 1.2pre Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: FreeBSD Current Subject: Re: Heavy I/O blocks FreeBSD box for several seconds X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jul 2011 07:49:16 -0000 on 12/07/2011 00:48 Arnaud Lacombe said the following: > Hi, > > On Mon, Jul 11, 2011 at 5:14 PM, Andriy Gapon wrote: >> on 11/07/2011 23:33 Arnaud Lacombe said the following: >>> For the record, I would like to see enforced public review for _every_ >>> patch *before* it is checked in, as a strong rule. gcc system is >>> particularly interesting. But it is not likely to happen in FreeBSD >>> where FreeBSD committers are clearly more free than other at >>> checking-in un-publicly-reviewed stuff (especially _bad_ stuff). >>> >>> This would of course apply even to long-time committers, no matter how >>> it hurt their ego (which I definitively do not care about). >> >> Have you just volunteered to review all of the patches that I would like to >> commit? And are you prepared to take responsibility for quality of your reviews? >> I am sure that other developers will gladly accept your offer too. >> > _No-one_ can do all the reviews, especially not me (on a purely > technical level). OK, I see, so your plan heavily depends on other people doing something (actually, a lot) according to your ideals. I see how realistic this suggestion is. This is a volunteer project. So, people who want to get something done usually start with themselves, not with telling other people what they should do. > ACK must come from subsystem maintainers. Having > public review would allow the community review, which is now just not > possible today. So far I see that a number of requests for review posted to public mailing lists is greater than a number of actual reviews done. Also, notifications of all changes to the src tree are posted to public mailing lists, so post-commit reviews can also be easily performed. Not seeing too many of those, though. -- Andriy Gapon