From owner-svn-src-head@freebsd.org Mon Feb 10 05:24:55 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DFEE222D7D8; Mon, 10 Feb 2020 05:24:55 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 48GDqq3X5Zz40bR; Mon, 10 Feb 2020 05:24:55 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id 11YyjuFSl17ZD11YzjctL7; Sun, 09 Feb 2020 22:24:54 -0700 X-Authority-Analysis: v=2.3 cv=ZsqT1OzG c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=kj9zAlcOel0A:10 a=l697ptgUJYAA:10 a=iaTFZB6CAAAA:8 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=hFAfhol9mYH5f-FC4gUA:9 a=CjuIK1q_8ugA:10 a=uJid2lUzHGYA:10 a=QWXrQ9iV8q7LKaLQ9lfw:22 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id CC02D2DE; Sun, 9 Feb 2020 21:24:51 -0800 (PST) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id 01A5OpqT006983; Sun, 9 Feb 2020 21:24:51 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id 01A5Opqd006980; Sun, 9 Feb 2020 21:24:51 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <202002100524.01A5Opqd006980@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Li-Wen Hsu cc: "O. Hartmann" , Scott Long , src-committers , svn-src-all , svn-src-head Subject: Re: svn commit: r357710 - in head/sys: cam/ata cam/nvme cam/scsi ufs/ffs In-reply-to: References: <202002100023.01A0NKmY053556@repo.freebsd.org> <20200210060145.6920e8f5@thor.intern.walstatt.dynvpn.de> Comments: In-reply-to Li-Wen Hsu message dated "Mon, 10 Feb 2020 13:14:42 +0800." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sun, 09 Feb 2020 21:24:51 -0800 X-CMAE-Envelope: MS4wfKwDYZ2UKfg9H66yJcGpXM32yQxvjTAkxEO1n8oTNxRbkOUlV937CROM0Sd35NoweUxzwMLXf/9w22E6Dq3eKGVxpQPlxPruIlFKni/XuWhcAcWdU+2q oXkm3JKdxeJZuoIopxNoG+SiRseaSo3/k5oG+xAHQNoeYtnbjvBjSlI8hPVEaX8C/K2PS2FNEbS1UAysCvQgxPPXZyAWHmJPbLB28718klFQHqSwNI3kM4wf t017USq9DO8zzjW9HXuMynVQsWKyCdcTMPWVcWFoSaP2HRPs8MuLwnhRUhreMSeUnKAUys+LjBcWdbwG2DEGsfHjfywYhDI6opSnKBdKPuRQ5HQ3wTHAiCn7 4+VIVTSk X-Rspamd-Queue-Id: 48GDqq3X5Zz40bR X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-5.99 / 15.00]; NEURAL_HAM_MEDIUM(-0.99)[-0.991,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Feb 2020 05:24:55 -0000 In message , Li-Wen Hsu writes: > On Mon, Feb 10, 2020 at 1:02 PM O. Hartmann wrote: > > > > -----BEGIN PGP SIGNED MESSAGE----- > > Hash: SHA256 > > > > Am Mon, 10 Feb 2020 00:23:20 +0000 (UTC) > > Scott Long schrieb: > > > > > Author: scottl > > > Date: Mon Feb 10 00:23:20 2020 > > > New Revision: 357710 > > > URL: https://svnweb.freebsd.org/changeset/base/357710 > > > > > > Log: > > > Add rudamentary support for UFS to probe whether a block device support > s the > > > BIO_SPEEDUP command. Add complimentary support to the CAM periphs that > > > support it. > > > > > > Modified: > > > head/sys/cam/ata/ata_da.c > > > head/sys/cam/nvme/nvme_da.c > > > head/sys/cam/scsi/scsi_da.c > > > head/sys/ufs/ffs/ffs_softdep.c > > > head/sys/ufs/ffs/ffs_vfsops.c > > > > > > Modified: head/sys/cam/ata/ata_da.c > > > ========================================================================= > ===== > > > --- head/sys/cam/ata/ata_da.c Mon Feb 10 00:05:04 2020 (r357709) > > > +++ head/sys/cam/ata/ata_da.c Mon Feb 10 00:23:20 2020 (r357710) > > > @@ -50,6 +50,7 @@ __FBSDID("$FreeBSD$"); > > > #include > > > #include > > > #include > > > +#include > > > #include > > > #endif /* _KERNEL */ > > > > > > @@ -1565,6 +1566,10 @@ adagetattr(struct bio *bp) > > > { > > > int ret; > > > struct cam_periph *periph; > > > + > > > + /* TODO: tunable knob */ > > > + if (g_handleattr_int(bp, "GEOM::canspeedup", 1)) > > > + return (0); > > > > > > periph = (struct cam_periph *)bp->bio_disk->d_drv1; > > > cam_periph_lock(periph); > > > > > > Modified: head/sys/cam/nvme/nvme_da.c > > > ========================================================================= > ===== > > > --- head/sys/cam/nvme/nvme_da.c Mon Feb 10 00:05:04 2020 (r3 > 57709) > > > +++ head/sys/cam/nvme/nvme_da.c Mon Feb 10 00:23:20 2020 (r3 > 57710) > > > @@ -48,6 +48,7 @@ __FBSDID("$FreeBSD$"); > > > #include > > > #include > > > #include > > > +#include > > > #include > > > #endif /* _KERNEL */ > > > > > > @@ -699,6 +700,10 @@ ndagetattr(struct bio *bp) > > > { > > > int ret; > > > struct cam_periph *periph; > > > + > > > + /* TODO: tunable knob */ > > > + if (g_handleattr_int(bp, "GEOM::canspeedup", 1)) > > > + return (0); > > > > > > periph = (struct cam_periph *)bp->bio_disk->d_drv1; > > > cam_periph_lock(periph); > > > > > > Modified: head/sys/cam/scsi/scsi_da.c > > > ========================================================================= > ===== > > > --- head/sys/cam/scsi/scsi_da.c Mon Feb 10 00:05:04 2020 (r3 > 57709) > > > +++ head/sys/cam/scsi/scsi_da.c Mon Feb 10 00:23:20 2020 (r3 > 57710) > > > @@ -1942,6 +1942,10 @@ dagetattr(struct bio *bp) > > > int ret; > > > struct cam_periph *periph; > > > > > > + /* TODO: tunable knob for this */ > > > + if (g_handleattr_int(bp, "GEOM::canspeedup", 1)) > > > + return (0); > > > + > > > periph = (struct cam_periph *)bp->bio_disk->d_drv1; > > > cam_periph_lock(periph); > > > ret = xpt_getattr(bp->bio_data, bp->bio_length, bp->bio_attribute, > > > > > > Modified: head/sys/ufs/ffs/ffs_softdep.c > > > ========================================================================= > ===== > > > --- head/sys/ufs/ffs/ffs_softdep.c Mon Feb 10 00:05:04 2020 (r3 > 57709) > > > +++ head/sys/ufs/ffs/ffs_softdep.c Mon Feb 10 00:23:20 2020 (r3 > 57710) > > > @@ -1464,6 +1464,9 @@ softdep_send_speedup(struct ufsmount *ump, size_t s > hor > > > { > > > struct buf *bp; > > > > > > + if ((ump->um_flags & UM_CANSPEEDUP) == 0) > > > + return; > > > + > > > bp = malloc(sizeof(*bp), M_TRIM, M_WAITOK | M_ZERO); > > > bp->b_iocmd = BIO_SPEEDUP; > > > bp->b_ioflags = flags; > > > > > > Modified: head/sys/ufs/ffs/ffs_vfsops.c > > > ========================================================================= > ===== > > > --- head/sys/ufs/ffs/ffs_vfsops.c Mon Feb 10 00:05:04 2020 (r3 > 57709) > > > +++ head/sys/ufs/ffs/ffs_vfsops.c Mon Feb 10 00:23:20 2020 (r3 > 57710) > > > @@ -794,7 +794,7 @@ ffs_mountfs(devvp, mp, td) > > > struct ucred *cred; > > > struct g_consumer *cp; > > > struct mount *nmp; > > > - int candelete; > > > + int candelete, canspeedup; > > > off_t loc; > > > > > > fs = NULL; > > > @@ -1009,6 +1009,13 @@ ffs_mountfs(devvp, mp, td) > > > ump->um_trimhash = hashinit(MAXTRIMIO, M_TRIM, > > > &ump->um_trimlisthashsize); > > > } > > > + } > > > + > > > + /* TODO: sysctl tunables, runtime modification */ > > > + len = sizeof(int); > > > + if (g_io_getattr("GEOM::canspeedup", cp, &len, &canspeedup) == 0) { > > > + if (canspeedup) > > > + ump->um_flags |= UM_CANSPEEDUP; > > > } > > > > > > ump->um_mountp = mp; > > > _______________________________________________ > > > svn-src-head@freebsd.org mailing list > > > https://lists.freebsd.org/mailman/listinfo/svn-src-head > > > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" > > > > It seems that this commit makes our systems to hang at the point, when tryi > ng to mount the > > root partition, last seen message on console is: > > > > [...] > > mountroot: waiting for device /dev/gpt/root... > > > > > > The root partitions on those systems resides on UFS2 formated SSDs (if this > has any relevance). > > The test in the CI seems also handing because of this. The full > backtrace is available at: > > https://ci.freebsd.org/job/FreeBSD-head-i386-test/8396/console > > The changes in the same build are r357709 and r357710. The previous is > arm only change so it seems less suspicious. > > Please help checking this. Thanks. My weekly (Sunday evening) builds: Two of my four machines hang, all with ada(4). The machines that boot use gmirror GEOMs as rootfs while the machines that hang mount the physical disk. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.